-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug for large_enum_variants #7677
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Please squash commits.
5bef29b
to
56f0c9a
Compare
Done. Thanks. |
@bors r+ Thanks! |
📌 Commit 56f0c9a has been approved by |
fix bug for large_enum_variants Fix the discussion problem in the issue of #7666 (comment) About the false positive problem of case: ```rust enum LargeEnum6 { A, B([u8;255]), C([u8;200]), } ```
💔 Test failed - checks-action_test |
@bors retry Added changelog |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fix the discussion problem in the issue of #7666 (comment)
About the false positive problem of case:
changelog: Fix largest_enum_variant wrongly identifying the second largest variant.