Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug for large_enum_variants #7677

Merged
merged 1 commit into from
Sep 30, 2021
Merged

fix bug for large_enum_variants #7677

merged 1 commit into from
Sep 30, 2021

Conversation

surechen
Copy link
Contributor

@surechen surechen commented Sep 16, 2021 •
edited by camsteffen
Loading

Fix the discussion problem in the issue of #7666 (comment)

About the false positive problem of case:

enum LargeEnum6 {
    A,
    B([u8;255]),
    C([u8;200]),
}

changelog: Fix largest_enum_variant wrongly identifying the second largest variant.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 16, 2021
camsteffen
camsteffen suggested changes Sep 22, 2021
View reviewed changes
clippy_lints/src/large_enum_variant.rs Outdated Show resolved Hide resolved
clippy_lints/src/large_enum_variant.rs Outdated Show resolved Hide resolved
camsteffen
camsteffen approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Please squash commits.

@surechen
Copy link
Contributor Author

Looking good! Please squash commits.

Done. Thanks.

@camsteffen
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Sep 30, 2021

📌 Commit 56f0c9a has been approved by camsteffen

@bors
Copy link
Collaborator

bors commented Sep 30, 2021

⌛ Testing commit 56f0c9a with merge cb72a2f...

bors added a commit that referenced this pull request Sep 30, 2021
@bors
Auto merge of #7677 - surechen:edit_large_enum_variant, r=camsteffen
cb72a2f 
fix bug for large_enum_variants

Fix the discussion problem in the issue of #7666 (comment)

About the false positive problem of case:
```rust
enum LargeEnum6 {
    A,
    B([u8;255]),
    C([u8;200]),
}
```
@bors
Copy link
Collaborator

bors commented Sep 30, 2021

💔 Test failed - checks-action_test

@camsteffen
Copy link
Contributor

@bors retry

Added changelog

@bors
Copy link
Collaborator

bors commented Sep 30, 2021

⌛ Testing commit 56f0c9a with merge a893eb9...

@bors
Copy link
Collaborator

bors commented Sep 30, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing a893eb9 to master...

@bors bors merged commit a893eb9 into rust-lang:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsteffen camsteffen camsteffen approved these changes

Assignees

@camsteffen camsteffen

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surechen @rust-highfive @camsteffen @bors