Add new primitive_method_to_numeric_cast lint
#13979
Open
+113
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
| // We get the type on which the `min`/`max` method of the `Ord` trait is implemented. | ||
| && let [ty] = generics.as_slice() | ||
| && let Some(ty) = ty.as_type() | ||
| // We get its name in case it's a primitive with an associated MIN/MAx constant. |
There was a problem hiding this comment.
typo
Suggested change
| // We get its name in case it's a primitive with an associated MIN/MAx constant. | |
| // We get its name in case it's a primitive with an associated MIN/MAX constant. |
| use rustc_lint::LateContext; | ||
| use rustc_middle::ty::{self, Ty}; | ||
|
|
||
| use super::PRIMITIVE_METHOD_TO_NUMERIC_CAST; |
There was a problem hiding this comment.
Are there primitive methods only max, min
If so might make sense to specify them at lint name
There was a problem hiding this comment.
Or confusing_method_to_numeric_cast?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13973.
I don't think we can make
fn_to_numeric_cast_anyto be emitted in some special cases. Its category cannot be changed at runtime.I think in this case, the best might be a specialized new lint so we can target exactly what we want.
changelog: Add new
primitive_method_to_numeric_castlint