Split needless_lifetime '_ suggestions into elidable_lifetime_names
#13960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
| /// ``` | ||
| #[clippy::version = "1.84.0"] | ||
| pub ELIDABLE_LIFETIME_NAMES, | ||
| pedantic, |
There was a problem hiding this comment.
This PR does two things at once: it not only splits the lint, but also moves part of it from complexity to pedantic. Since people would be able to silence the elidable_lifetime_names, shouldn't it stay into complexity?
My rationale is that an unused variable will get flagged if it doesn't start with _, why shouldn't we continue to do the same with unused lifetimes?
There was a problem hiding this comment.
Since a good number of people want to silence it we generally take that as an indicator that it should be moved into pedantic
I don't think it's as severe as unused variables since the lifetimes are still used even though they could be elided
Alexendoo
force-pushed
the
split-needless-lifetimes
branch
from
5b9427e to
03ada72
Compare
Alexendoo
force-pushed
the
split-needless-lifetimes
branch
from
03ada72 to
9d98207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13514
changelog: Split [
needless_lifetime] suggestions that use'_into a new pedantic lint [elidable_lifetime_names]