Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adding_lints): usage of early vs late lint pass #13955

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −4
Open

fix(adding_lints): usage of early vs late lint pass #13955

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0625f4
fix(adding_lints): usage of early vs late lint pass
aaron-ang Jan 6, 2025
16ee014
Update adding_lints.md
aaron-ang Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions book/src/development/adding_lints.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@ either [`EarlyLintPass`][early_lint_pass] or [`LateLintPass`][late_lint_pass].

In short, the `EarlyLintPass` runs before type checking and
[HIR](https://rustc-dev-guide.rust-lang.org/hir.html) lowering and the `LateLintPass`
has access to type information. Consider using the `LateLintPass` unless you need
something specific from the `EarlyLintPass`.
has access to type information. Consider using the `EarlyLintPass` unless you need
something specific from the `LateLintPass`.
aaron-ang marked this conversation as resolved.
Show resolved Hide resolved

Since we don't need type information for checking the function name, we used
`--pass=early` when running the new lint automation and all the imports were
Expand Down
Loading