Don't emit machine applicable map_flatten lint if there are code comments
#13940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
fix-map_flatten-suggestion
branch
from
65cf751 to
fbc1f00
Compare
|
Fixed fmt error. |
| @@ -17,10 +17,15 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>, recv: &Expr<'_>, map_ | |||
| let mut applicability = Applicability::MachineApplicable; | |||
|
|
|||
| let closure_snippet = snippet_with_applicability(cx, map_arg.span, "..", &mut applicability); | |||
| let span = expr.span.with_lo(map_span.lo()); | |||
| // If the methods are separated with comments, we don't apply suggestion automatically. | |||
| if applicability != Applicability::Unspecified && span_contains_comment(cx.tcx.sess.source_map(), span) { | |||
There was a problem hiding this comment.
Is it really useful to check for the very unlikely Unspecified case here? Sure, it speeds things up a bit in case it matches, but what is the chance?
There was a problem hiding this comment.
This is unreachable afaict (snippet_with_applicability never changes it to Unspecified)
There was a problem hiding this comment.
I'm starting to suspect it will not even change it to HasPlaceholders either (see #13941).
There was a problem hiding this comment.
I don't mind removing it if preferred.
GuillaumeGomez
force-pushed
the
fix-map_flatten-suggestion
branch
from
fbc1f00 to
78225cc
Compare
|
Removed the |
xFrednet
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8528.
Similar to #13911, if there are code comments, we don't want to remove them automatically.
changelog: Don't emit machine applicable
map_flattenlint if there are code commentsr? @xFrednet