no_mangle attribute requires unsafe in Rust 2024 #13631
Open
+164
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-uoowutzkvsrk
branch
from
eac1563
to
8052451
Compare
|
Should the lint documentation also show |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests without unsafe must not run in edition 2024. Also, error messages have been modified to include the full attribute, so that a use of
#[unsafe(no_mangle)]does not produce an error message containing#[no_mangle].changelog: [
no_mangle_attribute]: handle#[unsafe(no_mangle)]as well