Explain why clippy's HIR const eval exists #13615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
clippy_utils/src/consts.rs
Outdated
| //! | ||
| //! This cannot use rustc's const eval, aka miri, as arbitrary hir expressions cannot be lowered to | ||
| //! executable MIR bodies, so we have to do this instead. If hir expressions gain the ability to be | ||
| //! lowered to executable mir bodies, this should be removed. |
There was a problem hiding this comment.
Do we have some issue/PR which we can link to track when it happens
There was a problem hiding this comment.
Not that I know of, I don't think it's even a goal. That's why I used "if" instead of "when".
There was a problem hiding this comment.
HIR expressions are, practically, never going to gain that ability. We would have to maintain a translation layer in clippy for this.
There was a problem hiding this comment.
Shall I add a note to say "but this is practically never planned."?
GnomedDev
force-pushed
the
document-constevalctx-point
branch
from
97381d3
to
339c4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I initially found this, I was wondering why clippy wasn't just using miri, but after some discussion with some rustc folks let's document why.
changelog: none