Mark uninlined_format_args as pedantic #10265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jan 31, 2023
3434: Make clippy happy for Rust 1.67, allow `uninlined_format_args` r=Kerollmops a=dureuill # Pull Request This PR allows `uninlined_format_args` in CI for clippy. This is due to rust-lang/rust-clippy#10087, which in particular has correctness issues wrt edition 2018 crates, and is a big change altogether. rust-lang/rust-clippy#10265 is already open in order to change the category of this lint to "pedantic", meaning that if this latter PR merges, a future Rust release will accept our code unmodified wrt uninlined format arguments. As a result, this PR introduces the following changes: 1. Allow `uninlined_format_args` in the clippy command in CI. 2. Use rewind rather than seek(0) 3. Remove lifetimes that clippy deems needless. Co-authored-by: Louis Dureuil <[email protected]>
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jan 31, 2023
Mark uninlined_format_args as pedantic Fixes #10087 We should restore this when rust-analyzer support gets better. Worth filing an issue to track.
|
💔 Test failed - checks-action_test |
|
👎 I think we should reach a consensus on #10087 first - I honestly don't think we will gain anything if we release this change in 3 months per my comments in that issue |
|
@nyurik I've already stated my disagreement on that point there, but yeah let's continue on Zulip |
|
Also in general when a lot of people are disabling a lint our attitude is to "shoot first ask questions later", I'd rather disable this and get it uplifted to at least beta. |
|
@bors r=Alexendoo |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Manishearth
added
the
beta-nominated
|
Being uplifted in rust-lang/rust#107743 (comment) |
|
Thank you for fixing this! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2023
…crum Release 1.67.1 - Revert back to LlvmArchiveBuilder on all platforms rust-lang#107360 - 🚨 fix unsoundness in bootstrap cache code rust-lang#105624 - Mark uninlined_format_args as pedantic rust-lang/rust-clippy#10265 - Revert "switch to the macos-12-xl builder" rust-lang#107574 r? `@Mark-Simulacrum`
argerus
added a commit
to boschglobal/kuksa.val
that referenced
this pull request
Feb 11, 2023
This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265 https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args
argerus
added a commit
to boschglobal/kuksa.val
that referenced
this pull request
Feb 11, 2023
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Feb 12, 2023
Pkgsrc changes: * checksums only. Upstream changes: Version 1.67.1 (2023-02-09) =========================== - [Fix interoperability with thin archives.] (rust-lang/rust#107360) - [Fix an internal error in the compiler build process.] (rust-lang/rust#105624) - [Downgrade `clippy::uninlined_format_args` to pedantic.] (rust-lang/rust-clippy#10265)
SebastianSchildt
pushed a commit
to eclipse/kuksa.val
that referenced
this pull request
Feb 13, 2023
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265
flip1995
added
beta-accepted
lukasmittag
pushed a commit
to boschglobal/kuksa.val
that referenced
this pull request
Mar 9, 2023
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265
flip1995
removed
the
beta-accepted
javiergold112
pushed a commit
to javiergold112/symmetrical-invention
that referenced
this pull request
Jan 29, 2024
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265
argerus
added a commit
to eclipse-kuksa/kuksa-databroker
that referenced
this pull request
Mar 19, 2024
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265
argerus
added a commit
to eclipse-kuksa/kuksa-databroker
that referenced
this pull request
Mar 19, 2024
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265
argerus
added a commit
to eclipse-kuksa/kuksa-databroker
that referenced
this pull request
Mar 20, 2024
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10087
We should restore this when rust-analyzer support gets better. Worth filing an issue to track.
changelog: Mark [
uninlined_format_args] aspedantic