Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark uninlined_format_args as pedantic #10265

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Jan 31, 2023

Fixes #10087

We should restore this when rust-analyzer support gets better. Worth filing an issue to track.

changelog: Mark [uninlined_format_args] as pedantic

@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 31, 2023
bors bot added a commit to meilisearch/meilisearch that referenced this pull request Jan 31, 2023
3434: Make clippy happy for Rust 1.67, allow `uninlined_format_args` r=Kerollmops a=dureuill

# Pull Request

This PR allows `uninlined_format_args` in CI for clippy.

This is due to rust-lang/rust-clippy#10087, which in particular has correctness issues wrt edition 2018 crates, and is a big change altogether. rust-lang/rust-clippy#10265 is already open in order to change the category of this lint to "pedantic", meaning that if this latter PR merges, a future Rust release will accept our code unmodified wrt uninlined format arguments.

As a result, this PR introduces the following changes:

1. Allow `uninlined_format_args` in the clippy command in CI.
2. Use rewind rather than seek(0)
3. Remove lifetimes that clippy deems needless.

Co-authored-by: Louis Dureuil <[email protected]>
@llogiq
Copy link
Contributor

llogiq commented Jan 31, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 31, 2023

📌 Commit b4e2b48 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 31, 2023

⌛ Testing commit b4e2b48 with merge f95333d...

bors added a commit that referenced this pull request Jan 31, 2023
Mark uninlined_format_args as pedantic

Fixes #10087

We should restore this when rust-analyzer support gets better. Worth filing an issue to track.
@bors
Copy link
Collaborator

bors commented Jan 31, 2023

💔 Test failed - checks-action_test

@nyurik
Copy link
Contributor

nyurik commented Jan 31, 2023

👎 I think we should reach a consensus on #10087 first - I honestly don't think we will gain anything if we release this change in 3 months per my comments in that issue

@Manishearth
Copy link
Member Author

@nyurik I've already stated my disagreement on that point there, but yeah let's continue on Zulip

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/uninlined_format_args.20category.20take.202

@Manishearth
Copy link
Member Author

Also in general when a lot of people are disabling a lint our attitude is to "shoot first ask questions later", I'd rather disable this and get it uplifted to at least beta.

@Manishearth
Copy link
Member Author

@bors r=Alexendoo

@bors
Copy link
Collaborator

bors commented Jan 31, 2023

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Collaborator

bors commented Jan 31, 2023

📌 Commit b4e2b48 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 31, 2023

⌛ Testing commit b4e2b48 with merge 2880dcc...

@bors
Copy link
Collaborator

bors commented Jan 31, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 2880dcc to master...

@bors bors merged commit 2880dcc into rust-lang:master Jan 31, 2023
@Manishearth Manishearth deleted the uninlined-fmt-pedantic branch January 31, 2023 20:12
@Manishearth Manishearth added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 31, 2023
@Manishearth
Copy link
Member Author

Being uplifted in rust-lang/rust#107743 (comment)

@workingjubilee
Copy link
Member

Thank you for fixing this!

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2023
…crum

Release 1.67.1

- Revert back to LlvmArchiveBuilder on all platforms rust-lang#107360
- 🚨 fix unsoundness in bootstrap cache code rust-lang#105624
- Mark uninlined_format_args as pedantic rust-lang/rust-clippy#10265
- Revert "switch to the macos-12-xl builder" rust-lang#107574

r? `@Mark-Simulacrum`
argerus added a commit to boschglobal/kuksa.val that referenced this pull request Feb 11, 2023
This lint was promoted from "pedantic" in Rust 1.67.0.
It was subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args
argerus added a commit to boschglobal/kuksa.val that referenced this pull request Feb 11, 2023
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Feb 12, 2023
Pkgsrc changes:
 * checksums only.

Upstream changes:

Version 1.67.1 (2023-02-09)
===========================

- [Fix interoperability with thin archives.]
  (rust-lang/rust#107360)
- [Fix an internal error in the compiler build process.]
  (rust-lang/rust#105624)
- [Downgrade `clippy::uninlined_format_args` to pedantic.]
  (rust-lang/rust-clippy#10265)
SebastianSchildt pushed a commit to eclipse/kuksa.val that referenced this pull request Feb 13, 2023
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 2, 2023
lukasmittag pushed a commit to boschglobal/kuksa.val that referenced this pull request Mar 9, 2023
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
@flip1995 flip1995 removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 10, 2023
bors added a commit that referenced this pull request Mar 10, 2023
Update changelog for beta-accepted labels

Roses are red
Violets are blue
r? `@xFrednet` is better at this
I can't rhyme.

#10423
#10265

changelog: none
javiergold112 pushed a commit to javiergold112/symmetrical-invention that referenced this pull request Jan 29, 2024
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
argerus added a commit to eclipse-kuksa/kuksa-databroker that referenced this pull request Mar 19, 2024
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
argerus added a commit to eclipse-kuksa/kuksa-databroker that referenced this pull request Mar 19, 2024
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
argerus added a commit to eclipse-kuksa/kuksa-databroker that referenced this pull request Mar 20, 2024
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporarily downgrade uninlined_format_args (to pedantic or nursery)
7 participants