Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make niches into nices #18973

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make niches into nices #18973

wants to merge 4 commits into from

Conversation

ThouCheese
Copy link
Contributor

@ThouCheese ThouCheese commented Jan 18, 2025 •
edited
Loading

Format niche information like so:
image

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2025
Veykril
Veykril reviewed Jan 20, 2025
View reviewed changes
crates/ide/src/hover/render.rs Outdated Show resolved Hide resolved
crates/ide/src/hover/render.rs Outdated Show resolved Hide resolved
lnicola
lnicola approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, we can fix this at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril left review comments

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThouCheese @lnicola @Veykril @rustbot