Add a validity testcase for uninhabited variants #4805
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
meithecatte
force-pushed
the
uninhabited-enum-validity
branch
from
7a2c7c7 to
df5113a
Compare
RalfJung
reviewed
Jan 5, 2026
|
|
||
| let val = 1u32; | ||
| let ptr = (&raw const val).cast::<E>(); | ||
| unsafe { ptr.read() }; //~ ERROR: encountered an uninhabited enum variant |
Member
There was a problem hiding this comment.
A simple transmute from 1u32 should have the same result, right? That would even take care of the size check.
Member
Yeah, we probably mostly test this via const-eval tests... but can't hurt to also have a Miri test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this testcase in a random unmerged branch of mine. Looks like I wrote it as part of my work on rust-lang/rust#138961, and then forgot to submit it when plans wrt the scope of that PR have changed.
I have double checked by grepping for the error message and it looks like we still don't have any similar tests in miri.