Skip to content

Conversation

@ohadravid
Copy link

This PR adds support for the Fls{Alloc,GetValue,SetValue,Free} functions that are available on Windows. They enable native thread-local storage with destructor callbacks (MSDN).

I also have a PR to std that switches the default impl to use these functions, but I think supporting them in Miri can be useful anyway 🪟

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2025

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Dec 25, 2025
@rustbot

This comment has been minimized.

@RalfJung
Copy link
Member

Thanks for the PR!
I would prefer to do this only if actually needed by std. So let's see how that PR goes.

@RalfJung RalfJung added S-blocked-on-rust Status: Blocked on landing a Rust PR and removed S-waiting-on-review Status: Waiting for a review to complete labels Dec 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

☔ The latest upstream changes (possibly d04a627) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked-on-rust Status: Blocked on landing a Rust PR S-waiting-on-author Status: Waiting for the PR author to address review comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants