Add support for SSH interactive authentication #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing documentation
ehuss
reviewed
Aug 26, 2023
Comment on lines
+560
to
+562
| let text = malloc(response_bytes.len()); | ||
| response.text = text as *mut c_char; | ||
| response.length = response_bytes.len() as u32; |
There was a problem hiding this comment.
There seems to be an issue here. The response is never copied into the buffer created via malloc.
I think this also needs a check for a null return from malloc.
I'm only partially confident this is the correct way to handle this. From what I can tell, ssh2 has its own allocation routines that are part of the session, but I don't think the rust side exposes that, and I think it always defaults to libc malloc/free, so I don't think it is a problem. However, I'm a bit nervous about this manual memory handling with APIs that don't really document the behavior.
| let response = &mut *responses.offset(i as isize); | ||
| let response_bytes = wrapped_responses[i as usize].as_bytes(); | ||
|
|
||
| // libgit2 frees returned strings |
There was a problem hiding this comment.
This is the ssh2 library that is freeing the memory, not git2 right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For lifetime reasons,
Crednow doesn't always carry agit_credand thereforeCred::unwrap()may now panic if called on aCredcreated usingCred::ssh_interactive(); this is the only backwards-incompatible changeWithout leaking memory or memorizing created handlers in
RemoteCallbacksit's not possible to have individual handler for each SSH interactiveCred, so I compromized and put the handler directly intoRemoteCallbacksAlso, since
libgit2only ships with dummytypedefs forLIBSSH2_USERAUTH_KBDINT_PROMPTandLIBSSH2_USERAUTH_KBDINT_PROMPT,libssh2-sysis now a direct dependency for thesshfeature