add git_jit_type_is_float() #51
Conversation
Added more unit tests and updated description |
gcc/jit/docs/topics/types.rst
Outdated
| .. function:: int\ | ||
| gcc_jit_type_is_float (gcc_jit_type *type) | ||
|
|
||
| Return non-zero if the type is a float. |
There was a problem hiding this comment.
Now that I see this, I believe we should rename the function to make sure people do not think that this checks that this is the float type in C.
I would rename every float to floating_point (for instance gcc_jit_type_is_floating_point) unless you have a better idea.
There was a problem hiding this comment.
Yes, let's change it to gcc_jit_type_is_floating_point()
| @@ -60,6 +105,7 @@ verify_code (gcc_jit_context *ctxt, gcc_jit_result *result) | |||
| CHECK_VALUE (gcc_jit_vector_type_get_element_type(vector_type), double_type); | |||
| CHECK_VALUE (gcc_jit_vector_type_get_num_units(vector_type), 4); | |||
| CHECK (!gcc_jit_type_is_integral(vec_type)); | |||
| CHECK (gcc_jit_type_is_float(vec_type)); | |||
There was a problem hiding this comment.
I'm not sure this makes sense that this returns true on a vector type.
Is this the same for gcc_jit_type_is_integral?
There was a problem hiding this comment.
vector_type inherits from decorated_type, whose is_float method calls the is_float() method of the vector element.
I will add additional check for vectors.
zedar
force-pushed
the
add_git_jit_type_is_float
branch
2 times, most recently
from
09a6029 to
d3ac970
Compare
gcc/jit/libgccjit.cc
Outdated
| @@ -604,7 +604,7 @@ int | |||
| gcc_jit_type_is_bool (gcc_jit_type *type) | |||
| { | |||
| RETURN_VAL_IF_FAIL (type, FALSE, NULL, NULL, "NULL type"); | |||
|
|
|||
For gcc_jit_type_is_float() add unit tests and function description Rename gcc_jit_type_is_float to gcc_jit_type_is_floating improve description Remove unecessary spaces
zedar
force-pushed
the
add_git_jit_type_is_float
branch
from
d3ac970 to
a6d92cb
Compare
|
Thanks for your contribution! |
No description provided.