Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler family detection issue with clang-cl on macOS #1328

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix compiler family detection issue with clang-cl on macOS #1328

wants to merge 2 commits into from
+23 −14

Conversation

NobodyXu
Copy link
Collaborator

Fixed #1327

@NobodyXu NobodyXu requested a review from madsmtm December 22, 2024 13:57
@NobodyXu
Copy link
Collaborator Author

I can't know for sure if the compiler is clang-cl, so can't apply the workaround reliably.

Alternatively, we could combine cfg(macos) with accept cl flags check.

if both are true then it's likely clang-cl on macOS, which needs workaroud.

@NobodyXu NobodyXu requested a review from thomcc December 23, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm Awaiting requested review from madsmtm

@thomcc thomcc Awaiting requested review from thomcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler family detection issue with clang-cl on macOS
1 participant
@NobodyXu