fix(cargo_new): format members list of workspace in Cargo.toml #15085
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
Command-new
S-waiting-on-review
| @@ -999,6 +999,7 @@ fn update_manifest_with_new_member( | |||
| if was_sorted { | |||
| members.sort_by(|lhs, rhs| lhs.as_str().cmp(&rhs.as_str())); | |||
| } | |||
| members.fmt(); | |||
There was a problem hiding this comment.
On the surface, this looks like this solves the problem but it removes any user formatting, like comments.
See #11743 for an example of where using fmt has a negative impact.
There was a problem hiding this comment.
@epage yes, it removes the comments and user formatting.
closing the PR.
Thank You for your quick insight.
|
Per our contributing guide, we ask that features be marked as |
What does this PR try to resolve?
Fixes #15084
formats members list in workspace of Cargo.toml.
How should we test and review this PR?
Steps
Current Output:
Fixed Output:
can write tests if required.
Thank You