Dart: drop formatting and clean up code #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Nov 20, 2023
| use crate::common::{ErrorStore, FileMap}; | ||
| use askama::Template; |
There was a problem hiding this comment.
what changed in this file? Why is this diff so big?
There was a problem hiding this comment.
oh I merged class.rs into it because the split was kind of arbitrary and copied from cpp2. deleted now
There was a problem hiding this comment.
going to assume nothing else changed then
There was a problem hiding this comment.
Well there were some merging simplification changes, and changes to generated whitespace
|
Will this fix unicode-org/icu4x#4291? |
Manishearth
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #439