Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the secp256k1-sys codebase to version v0.6. #764

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

jlest01
Copy link
Contributor

@jlest01 jlest01 commented Nov 12, 2024

This PR updates the secp256k1-sys codebase to version v0.6.
I'm not sure if there are more steps involved, but these commits work fine in #716.

@apoelstra
Copy link
Member

Thanks for doing this! Before running the vendor script, can you update the version in secp256k1-sys/Cargo.toml from 0.10.0 to 0.11.0? We need to update the version in order to make this releaseable, and because our vendoring code embeds the full version into all the symbols, and changing the name of these symbols is a breaking change, we don't have the ability to do minor bumps.

Could you also add an initial commit to this PR which edits secp256k1-sys/vendor-libsecp.sh to remove the patch version from DEFAULT_VERSION_CODE? I think adding | cut -d_ -f1-2 to the current command that computes it will do this.

I don't know why I didn't think to do this years ago..

@jlest01 jlest01 force-pushed the update-06 branch 2 times, most recently from f29418e to c3ef482 Compare November 16, 2024 03:48
@jlest01
Copy link
Contributor Author

jlest01 commented Nov 16, 2024

@apoelstra thanks. I added two new initial commits.

@apoelstra
Copy link
Member

Can you also update the Cargo-recent.lock and Cargo-minimal.lock files in the repo?

@apoelstra
Copy link
Member

That should get CI passing -- then I can test the last commit and ACK it -- and then I'll ask you to squash everything, even though your change are logically separate and nicely separated. Because unfortunately none of the changes work without the others.

@jlest01
Copy link
Contributor Author

jlest01 commented Nov 17, 2024

@apoelstra done. Thanks

@jlest01
Copy link
Contributor Author

jlest01 commented Nov 17, 2024

I had squashed everything, but then I realized you asked to do it after the review.
Cargo-recent.lock and Cargo-minimal.lock were changed in d88e6c2

@apoelstra
Copy link
Member

utACK 0cdc758a56360bf58a851fe91085a327ec97685a

Thanks for iterating!!

If you squash everything I can do a tested ACK and merge it. (I already tested the tip so it will pass after squashing.)

@apoelstra
Copy link
Member

Err, utack 32a533c I mean. Copied the wrong commit.

@jlest01
Copy link
Contributor Author

jlest01 commented Nov 17, 2024

Thanks for reviewing. All commits squashed.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 06ab8d0; successfully ran local tests; thanks for iterating!

@apoelstra apoelstra merged commit 9acf667 into rust-bitcoin:master Nov 23, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants