Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 8.0.0 #462

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Release 8.0.0 #462

merged 1 commit into from
Oct 19, 2022

Conversation

sanket1729
Copy link
Member

@sanket1729 sanket1729 commented Sep 19, 2022 •
edited
Loading

@sanket1729 sanket1729 changed the title release 8.0.0 Release 8.0.0 Sep 19, 2022
@sanket1729 sanket1729 mentioned this pull request Sep 19, 2022
Closed
@sanket1729
Copy link
Member Author

I have also added the 8.0.0 milestone to the PRs that are blocking

@josediegorobles josediegorobles mentioned this pull request Sep 20, 2022
Closed
This was referenced Sep 29, 2022
Merged
Merged
sanket1729 added a commit that referenced this pull request Oct 1, 2022
@sanket1729
Merge #465: Add PsbtOutputExt::update_with_descriptor
2f1535e 
9a57e00 Ensure there are no duplicated leaf hashes in `tap_key_origins` (Alekos Filini)
1bbd13b Allow `non_witness_utxo` for segwit PSBTs (Alekos Filini)
9f63165 Append bip32 derivations instead of replacing the map entirely (Alekos Filini)
f46830c Add tests for `PsbtExt::update_output_with_descriptor` (Alekos Filini)
3148fb3 Correct error description for `UtxoUpdateError::MissingInputUtxo` (Alekos Filini)
03c25ec Add `PsbtOutputExt::update_with_descriptor` (Alekos Filini)

Pull request description:

  This essentially mirrors `PsbtInputExt::update_with_descriptor` but it works on PSBT outputs.

  To avoid code duplication, the current logic that deals with PSBT inputs has been generalized to handle both input and outputs with a new internal `PsbtFields` trait.

  -----

  I hope it's not too late to get this PR in the new 8.0 release (cc #462)

ACKs for top commit:
  apoelstra:
    ACK 9a57e00
  sanket1729:
    ACK 9a57e00. Not completely happy with internal trait abstraction. I may work on a future PR to abstract that into a function that takes 1) script pubkey and 2) descriptor and outputs the relevant fields that are added to the psbt.

Tree-SHA512: 595485b8aa6db665a120ff756c522b8e81858c06bf86dbda25e5b742f10ad537481351c0111b5f0946919f90f7784c8ff2c2e99b9f403f4607723f46ac608d38
@dr-orlovsky dr-orlovsky mentioned this pull request Oct 8, 2022
Merged
@darosior
Copy link
Contributor

What do you think of sneaking in #470 too? It breaks some APIs hence needs a major version bump.
The BIP is still only a PR to the bips repository, but the idea has now got an implementation in various softwares and the BIP itself received decent feedback. I'd be in favour of a small tweak to it but i can live without.

@apoelstra
Copy link
Member

I wouldn't mind getting #470 in. Yes, it's only a draft and may change, but we've got a bunch of other stuff in this library that's also subject to change (and a lot of stuff which is not specced out very well, or at all).

We definitely did 1.0 years too early here :)

@sanket1729 sanket1729 marked this pull request as ready for review October 19, 2022 18:41
@sanket1729 sanket1729 force-pushed the 8.0.0 branch 2 times, most recently from 50b6bc5 to 87949cc Compare October 19, 2022 19:43
@sanket1729
Copy link
Member Author

@darosior, I think #470 would take some time to get in :( and we would like to cut a release because it's been a long time, but don't have a rust-bitcoin 0.29 release.

@sanket1729
Copy link
Member Author

@apoelstra, perhaps #475 can be merged?

apoelstra
apoelstra approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3f451db

@apoelstra apoelstra merged commit fd9ef55 into rust-bitcoin:master Oct 19, 2022
sanket1729 added a commit to sanket1729/elements-miniscript that referenced this pull request Oct 21, 2022
@sanket1729
Merge commit 'fd9ef55f894e9de2705822e801ac08cc563fc06a' into update_2…
f5fa5ba 
…022_10

fd9ef55 (bitcoin-upstream/master) Merge rust-bitcoin/rust-miniscript#462: Release 8.0.0
notmandatory added a commit to bitcoindevkit/bdk that referenced this pull request Oct 27, 2022
@notmandatory
Merge #770: Upgrade to rust-bitcoin 0.29
5720e38 
c7a43d9 Remove unused code (Alekos Filini)
1ffd59d Upgrade to rust-bitcoin 0.29 (Alekos Filini)
ae4f4e5 Upgrade `rand` to `0.8` (Alekos Filini)
9854fd3 Remove deprecated address validators (Alekos Filini)

Pull request description:

  ### Description

  Upgrade BDK to rust-bitcoin 0.29

  Missing pieces:

  - [x] rust-miniscript `update_output_with_descriptor` - rust-bitcoin/rust-miniscript#465
  - [x] rust-miniscript 8.0.0 release - rust-bitcoin/rust-miniscript#462
  - [x] Upgrade rust-hwi to bitcoin 0.29 bitcoindevkit/rust-hwi#50
  - [x] Upgrade esplora-client to bitcoin 0.29 bitcoindevkit/rust-esplora-client#20
  - [x] Upgrade rand to 0.8 like secp256k1 did

  ### Notes to the reviewers

  The commits still need to be reordered and cleaned up

  ### Changelog notice

  - Upgrade rust-bitcoin to 0.29
  - Remove deprecated "address validators"

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK c7a43d9

Tree-SHA512: 718a1baf3613b31ec1de39fe63467ebee38617963a4ce0670a617e20fe4f46a57c5786933cdde6cfad9fc76ce0af08843f58844fb4a89f5948cb42c697f802ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanket1729 @darosior @apoelstra