Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reka llamaindex integration (llm and multi-modal-llm) #15753

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

findalexli
Copy link

Description

We are brining Reka to the llamaindex ecosystem via the llama-index-llms-reka and llama-index-multi-modal-llms-reka integration. Please refer to the readme llama-index-llms-reka and llama-index-llms-reka in each package for more documentation.

We provided the integration tests and mocked-up tests that do not require Reka API remote access.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • [ - ] Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [- ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [-] Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • [-] I have performed a self-review of my own code
  • [-] I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • [- ] My changes generate no new warnings
  • [-] I have added tests that prove my fix is effective or that my feature works
  • [- ] New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 30, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@findalexli
Copy link
Author

Hi there,

  1. let us now if you like us to take out the poetry lock file out of the commit
  2. We have not yet run the poetry build and `poetry publish' to publish our file. let us know at which point would those command be executed - or would your team like to publish them instead.

@logan-markewich logan-markewich self-assigned this Sep 2, 2024
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor nits

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) September 10, 2024 18:55
@logan-markewich
Copy link
Collaborator

It looks like I can't push to this PR

You'll want to install pants, run pants tailor llama-index-integrations/:: and add the files it creates in your new packages

auto-merge was automatically disabled September 12, 2024 23:01

Head branch was pushed to by a user without write access

@findalexli
Copy link
Author

hi @logan-markewich thanks! I added the build files generated by pants as you suggested. I also added you to our fork in case you need to push any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants