Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Style loss when taking screenshots #426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZhengIce
Copy link
Collaborator

fix:

  • Incomplete display of border style when taking screenshots

Copy link
Contributor

@zyc9012 zyc9012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wireframes are missing
image

@ZhengIce
Copy link
Collaborator Author

@zyc9012 By default, there is no border on the edge. What do you mean is that when taking screenshots, the border on the edge should also be added to display it

@zyc9012
Copy link
Contributor

zyc9012 commented Jul 13, 2023

@ZhengIce. Top and left border are not rendered for cell area because they are taken by row header bottom line and column header right line. But in screenshot we need to add them back. In case it overrides the manually set borders, you can try to draw it along with other default borders (or wireframe) to see if it affects anything visually.

@ZhengIce
Copy link
Collaborator Author

Okay, I will study it further.

@zyc9012 zyc9012 force-pushed the master branch 3 times, most recently from 471416d to 829cacb Compare April 5, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants