Correctly read symbols that start with numbers.#12
Open
jpe90 wants to merge 1 commit intorui314:masterfrom
Open
Correctly read symbols that start with numbers.#12jpe90 wants to merge 1 commit intorui314:masterfrom
jpe90 wants to merge 1 commit intorui314:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a stab at fixing #9 as a learning exercise. The changes will make values like '1a' or '-1a' be interpreted as a single symbol where before they were interpreted as a number followed by a symbol.
I added a couple test cases and everything seems to pass.. feedback is welcome if you have any!