Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: log the subprocess output #537

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore: log the subprocess output #537

merged 1 commit into from
Dec 17, 2024

Conversation

shubhammehra4
Copy link
Collaborator

Description of the change

Add debug logging for subprocess run for all cases, the debug logs are indented so they are easily readble

Linear Ticket

Resolves PRML-1049

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@shubhammehra4 shubhammehra4 force-pushed the chore.propensitySubprocessLog branch from f9af456 to 73d322c Compare December 17, 2024 13:00
@shubhammehra4 shubhammehra4 merged commit 61f9af4 into main Dec 17, 2024
12 of 18 checks passed
@shubhammehra4 shubhammehra4 deleted the chore.propensitySubprocessLog branch December 17, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpatchigolla dpatchigolla dpatchigolla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhammehra4 @dpatchigolla