Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output_type for tutorial #525

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class AuditIdStitcherModel(BaseModelType):
}

def __init__(self, build_spec: dict, schema_version: int, pb_version: str) -> None:
build_spec["materialization"] = {"output_type": "ephemeral"}
build_spec["materialization"] = {"output_type": "shell"}
super().__init__(build_spec, schema_version, pb_version)
self.recipe = ModelRecipe(self.build_spec)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class TutorialModel(BaseModelType):
}

def __init__(self, build_spec: dict, schema_version: int, pb_version: str) -> None:
build_spec["materialization"] = {"output_type": "shell"}
super().__init__(build_spec, schema_version, pb_version)

def get_material_recipe(self) -> PyNativeRecipe:
Expand Down
3 changes: 1 addition & 2 deletions src/predictions/profiles_mlcorelib/py_native/propensity.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ def __init__(
parent_folder: WhtFolder,
model_name: str,
) -> None:
# ephemeral materialization so that pb doesn't try to validate the output of the model
build_spec["materialization"] = {"output_type": "ephemeral"}
build_spec["materialization"] = {"output_type": "none"}
super().__init__(build_spec, schema_version, pb_version)
training_model_name = model_name + "_training"
training_spec = self._get_training_spec()
Expand Down
Loading