-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch remote schema async #5347
Draft
cisse21
wants to merge
9
commits into
master
Choose a base branch
from
feat.fetchRemoteSchemaAsync
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisse21
force-pushed
the
feat.fetchRemoteSchemaAsync
branch
3 times, most recently
from
December 6, 2024 05:18
05f985f
to
59ae13c
Compare
cisse21
commented
Dec 9, 2024
warehouse/router/sync.go
Outdated
r.statsFactory, | ||
) | ||
if err := r.SyncRemoteSchema(ctx, whManager, sh); err != nil { | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is there are wrong credentials over here
cisse21
force-pushed
the
feat.fetchRemoteSchemaAsync
branch
from
December 9, 2024 10:14
59ae13c
to
842a746
Compare
cisse21
force-pushed
the
feat.fetchRemoteSchemaAsync
branch
4 times, most recently
from
December 9, 2024 11:51
7883385
to
9415887
Compare
cisse21
force-pushed
the
feat.fetchRemoteSchemaAsync
branch
from
December 9, 2024 11:59
9415887
to
229b4c8
Compare
cisse21
force-pushed
the
feat.fetchRemoteSchemaAsync
branch
from
December 11, 2024 09:13
1c7ebd9
to
29e1254
Compare
cisse21
force-pushed
the
feat.fetchRemoteSchemaAsync
branch
from
December 11, 2024 09:36
29e1254
to
649b4a7
Compare
cisse21
force-pushed
the
feat.fetchRemoteSchemaAsync
branch
from
December 11, 2024 10:00
57579b5
to
1161fbb
Compare
cisse21
force-pushed
the
feat.fetchRemoteSchemaAsync
branch
from
December 11, 2024 12:42
420a53e
to
5702ec8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
< Replace with adequate description for this PR as per Pull Request document >
Linear Ticket
< Replace with Linear Link ( create or search linear ticket) or >
Security