Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: byte index to read singularEvent, propagate payload func to processor pipeline #5314

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Nov 20, 2024

Description

Use byte index to get event payload and propagate same to processor pipeline steps - using sync.OnceValue instead of go-kit/memoize so it can be propagated to other steps. This can be used in setting report payloads or settings event payloads to the error db.

Also updated tests to remove cases where processor picked up jobs from gateway that had multiple events - this hasn't been the case for a long time now.

Linear Ticket

Resolves PIPE-1717

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth marked this pull request as draft November 20, 2024 11:08
@Sidddddarth Sidddddarth force-pushed the chore.propagatePayloadMarshalFuncToPipeline branch 2 times, most recently from 77224ff to d5f7134 Compare November 20, 2024 12:21
@Sidddddarth Sidddddarth force-pushed the chore.propagatePayloadMarshalFuncToPipeline branch 9 times, most recently from 2854a3f to e666034 Compare November 21, 2024 06:26
@Sidddddarth Sidddddarth force-pushed the chore.propagatePayloadMarshalFuncToPipeline branch from e666034 to b0d7048 Compare November 21, 2024 06:33
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 85.07463% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.54%. Comparing base (f908e21) to head (f9498ae).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
processor/processor.go 84.84% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5314      +/-   ##
==========================================
- Coverage   73.57%   73.54%   -0.03%     
==========================================
  Files         424      424              
  Lines       59935    59961      +26     
==========================================
+ Hits        44095    44098       +3     
- Misses      13370    13397      +27     
+ Partials     2470     2466       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth marked this pull request as ready for review November 21, 2024 07:00
Copy link

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added Stale and removed Stale labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant