-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: webhook v2 spec upgrade #5224
base: master
Are you sure you want to change the base?
Conversation
8df117d
to
42a0c5b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5224 +/- ##
==========================================
+ Coverage 74.68% 74.77% +0.08%
==========================================
Files 437 437
Lines 61240 61282 +42
==========================================
+ Hits 45737 45822 +85
+ Misses 12954 12924 -30
+ Partials 2549 2536 -13 ☔ View full report in Codecov by Sentry. |
@@ -74,8 +76,8 @@ func (*noopService) Regulations() []string { | |||
} | |||
|
|||
func (*noopService) SourceTransformerVersion() string { | |||
// v0 is deprecated | |||
return V1 | |||
// v0 is deprecated and upgrading to v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
features_impl.go returns version based on upgradedToSourceTransformV2
value received by /features response from transformer
when does this come into picture ? and what difference it makes returning v1 vs. v2 here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used in some test cases as a placeholder for transformer service. This used to return v0 earlier but as v0 is deprecated v1 is the ideal response.
This doesn't affect the actual logic anywhere.
Description
Linear Ticket
Resolves INT-2802
Security