Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warehouse transformer #5205

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Oct 17, 2024

Description

Linear Ticket

  • Resolves PIPE-1585

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the feat.warehouse-transformer branch from a941966 to 22b287b Compare October 17, 2024 07:49
@achettyiitr achettyiitr requested a review from lvrach October 17, 2024 07:49
@achettyiitr achettyiitr force-pushed the feat.warehouse-transformer branch from 22b287b to 5ae4838 Compare October 17, 2024 07:51
metadata := clientEvents[0].Metadata

defer func() {
tags := stats.Tags{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a tag implementation to distinguish between go or js-client

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already prefixing warehouse_ as part of the stat name.

@achettyiitr achettyiitr force-pushed the feat.warehouse-transformer branch 3 times, most recently from 1a41ba4 to e414cca Compare October 18, 2024 04:45
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 76.08696% with 341 lines in your changes missing coverage. Please review.

Project coverage is 73.22%. Comparing base (9683021) to head (277bc71).

Files with missing lines Patch % Lines
warehouse/transformer/identify.go 58.55% 44 Missing and 19 partials ⚠️
warehouse/transformer/setdata.go 52.03% 45 Missing and 14 partials ⚠️
warehouse/transformer/track.go 61.65% 34 Missing and 17 partials ⚠️
warehouse/transformer/extract.go 58.62% 16 Missing and 8 partials ⚠️
warehouse/transformer/alias.go 55.31% 14 Missing and 7 partials ⚠️
warehouse/transformer/group.go 55.31% 14 Missing and 7 partials ⚠️
warehouse/transformer/page.go 55.31% 14 Missing and 7 partials ⚠️
warehouse/transformer/screen.go 55.31% 14 Missing and 7 partials ⚠️
warehouse/transformer/transformer.go 84.96% 16 Missing and 4 partials ⚠️
warehouse/transformer/merge.go 90.97% 8 Missing and 4 partials ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5205      +/-   ##
==========================================
- Coverage   74.71%   73.22%   -1.50%     
==========================================
  Files         417      445      +28     
  Lines       49913    60503   +10590     
==========================================
+ Hits        37294    44303    +7009     
- Misses      10199    13679    +3480     
- Partials     2420     2521     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr force-pushed the feat.warehouse-transformer branch 2 times, most recently from 1578967 to 277bc71 Compare October 18, 2024 11:33
@achettyiitr achettyiitr force-pushed the feat.warehouse-transformer branch 2 times, most recently from 404773f to c798625 Compare October 21, 2024 01:40
@achettyiitr achettyiitr requested a review from lvrach October 21, 2024 01:42
@achettyiitr achettyiitr force-pushed the feat.warehouse-transformer branch 2 times, most recently from 9f36c96 to 3f956b4 Compare October 21, 2024 05:47
@achettyiitr achettyiitr force-pushed the feat.warehouse-transformer branch from 3f956b4 to a1fd52e Compare October 21, 2024 06:32
@achettyiitr achettyiitr force-pushed the feat.warehouse-transformer branch from 11996b9 to 14aa043 Compare October 21, 2024 09:54
@achettyiitr achettyiitr requested a review from ktgowtham October 21, 2024 09:54
Copy link

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label Nov 11, 2024
@github-actions github-actions bot closed this Nov 18, 2024
@achettyiitr achettyiitr reopened this Dec 18, 2024
@github-actions github-actions bot removed the Stale label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants