Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release gha #20

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: release gha #20

merged 1 commit into from
Apr 24, 2024

Conversation

atzoum
Copy link
Collaborator

@atzoum atzoum commented Apr 17, 2024 •
edited
Loading

Description

Automating profiles-pycorelib release process through an action that can be triggered manually (for now) after a pywht release is created:

Inputs

  • whtRelease: the version to release, a wht release of the same version needs to exist
  • releaseRef: the branch to use for creating the tag and the release

Steps

  • Checkout the $releaseRef branch
  • Fallback to main if $releaseRef branch doesn't exist
  • Create the tag
  • Build the wheel file for profiles-pycorelib.
  • Tar gz dist folder of profiles-pycorelib
  • Create the tag and the release with its assets

Linear Ticket

Resolves PRO-2419

@atzoum atzoum force-pushed the chore.ciActions branch 5 times, most recently from 49a2b56 to d5a2837 Compare April 17, 2024 06:49
@atzoum atzoum requested review from nishantsharma and sprksh April 23, 2024 05:10
nishantsharma
nishantsharma approved these changes Apr 23, 2024
View reviewed changes
Copy link

@nishantsharma nishantsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But, better to merge when the release process is also updated to use these GHA.

@atzoum
Copy link
Collaborator Author

atzoum commented Apr 23, 2024

LGTM. But, better to merge when the release process is also updated to use these GHA.

This change doesn't affect the existing release process and both old and new processes can coexist after it gets merged

@atzoum atzoum merged commit 49715ba into main Apr 24, 2024
@atzoum atzoum deleted the chore.ciActions branch April 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhammehra4 shubhammehra4 shubhammehra4 approved these changes

@nishantsharma nishantsharma nishantsharma approved these changes

@yajuaryarudderstack yajuaryarudderstack Awaiting requested review from yajuaryarudderstack

@chandumlg chandumlg Awaiting requested review from chandumlg

@sprksh sprksh Awaiting requested review from sprksh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atzoum @nishantsharma @shubhammehra4