-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few fixes and features #596
Open
louiecaulfield
wants to merge
12
commits into
rubysherpas:rails4
Choose a base branch
from
louiecaulfield:rails4
base: rails4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
630407a
made gemspec valid
louiecaulfield e46304d
Little updates to make use of single CSS possible
louiecaulfield 032d46e
Use proper localisation string for post edit button
louiecaulfield 5c45167
Properly wrap header in reply form
louiecaulfield cd39afe
Added member info to post partial
louiecaulfield f9b0c61
Removed trailing apostrophe
louiecaulfield 6929197
Implemented post preview
louiecaulfield 1145333
Verify post visibility when finding last visible post
louiecaulfield d96d63e
Fix sort order
louiecaulfield e68a7af
Merge pull request #589 from Fodoj/rails4
louiecaulfield 848958c
Emoji fix
louiecaulfield b63e455
Merge remote-tracking branch 'radar/rails4' into rails4
louiecaulfield File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,40 @@ | ||
//= require select2 | ||
//= require jquery | ||
|
||
var Forem = {}; | ||
Forem.routes = {}; | ||
|
||
var textareaSelector = 'textarea.new-post'; | ||
var lastRenderedMarkdown = ""; | ||
var previewRefreshTimeout = 100; | ||
|
||
$(function() { | ||
if($(textareaSelector).length) { | ||
fetch_preview(); | ||
} | ||
}); | ||
|
||
function fetch_preview() | ||
{ | ||
markdownText = $(textareaSelector).val(); | ||
if(markdownText == lastRenderedMarkdown) { | ||
setTimeout(fetch_preview, previewRefreshTimeout); | ||
return; | ||
} | ||
|
||
lastRenderedMarkdown = markdownText; | ||
$.post( | ||
$(textareaSelector).data("previewUrl"), | ||
{ markdown : markdownText }, | ||
function(result) { | ||
update_preview(result); | ||
setTimeout(fetch_preview, previewRefreshTimeout); | ||
} | ||
); | ||
} | ||
|
||
function update_preview(data) | ||
{ | ||
selector = $(textareaSelector).data("previewElementSelector"); | ||
$(selector).html(data.html); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,4 @@ | |
<% end %> | ||
|
||
<%= f.submit :class => "btn btn-primary" %> | ||
<% end %> | ||
<% end %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing some indentation... just a small nitpick.
I like that you've removed the duplication in the
_reply_to_post
partial.