-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Expand urls in tweets #43
base: master
Are you sure you want to change the base?
Conversation
Stub expand url call in test
Testing this requires the previous pull requests... before merging, ensure you can |
|
||
describe ExpandUrl do | ||
|
||
it 'should be tested' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Pretty please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. I was thinking of also moving the expansion to the tweet processing leve, but since that would be destructive, was considering adding an 'original tweet text' field. Unrelated, I want to add a 'context' field that represents the search term the tweet was found from, then... eventually extract most of this as an engine.. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm rewriting this to add a tweet_display_text field that is populated at import time.. should I continue to update this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make it easy to merge and I'll do so.. Keep adding tests and I don't mind merging at a faster rate, given the feature is not going to bloat the code base -- aka, it is derived from something needed, with a reason that outweighs the expense of maintenance moving forward..
Needs tests and redesign, but otherwise works