Add student import to new admin students page

Author: americac

.gitignore

@@ -61,3 +61,7 @@
 Library/
 
 .idea
+
+# Ignore macOS metadata files
+.DS_Store
+**/.DS_Store

app/controllers/admin_v2/students_controller.rb

@@ -111,6 +111,24 @@ def add_transaction
       end
     end
 
+    def import
+      return redirect_with_missing_file_error if params[:csv_file].blank?
+
+      begin
+        results = BulkStudentImportService.import_from_csv(params[:csv_file].path)
+        redirect_with_import_results(results)
+      rescue CSV::MalformedCSVError => e
+        redirect_to admin_v2_students_path, alert: "Invalid CSV format: #{e.message}"
+      end
+    end
+
+    def template
+      send_data BulkStudentImportService.generate_csv_template,
+                filename: "student_import_template.csv",
+                type: "text/csv",
+                disposition: "attachment"
+    end
+
     private
 
     def set_discarded_student
@@ -153,6 +171,62 @@ def validate_transaction_params
       errors << t("admin_v2.students.add_transaction.errors.reason_blank") if transaction_reason.blank?
       errors
     end
+
+    def redirect_with_missing_file_error
+      redirect_to admin_v2_students_path, alert: "Please select a CSV file"
+    end
+
+    def redirect_with_import_results(results)
+      return redirect_with_no_results_error if results.empty?
+
+      created, skipped, failed = partition_results(results)
+      success_messages = build_success_messages(created, skipped)
+
+      if failed.any?
+        redirect_with_mixed_results(success_messages, failed)
+      else
+        redirect_to admin_v2_students_path, notice: success_messages.join(". ")
+      end
+    end
+
+    def redirect_with_no_results_error
+      redirect_to admin_v2_students_path, alert: "No students found in CSV file"
+    end
+
+    def partition_results(results)
+      [
+        results.select(&:created?),
+        results.select(&:skipped?),
+        results.select(&:failed?)
+      ]
+    end
+
+    def build_success_messages(created, skipped)
+      messages = []
+      messages << build_created_message(created) if created.any?
+      messages << build_skipped_message(skipped) if skipped.any?
+      messages
+    end
+
+    def build_created_message(created)
+      usernames = created.map { |item| item.student.username }
+      "Successfully created #{created.count} students: #{usernames.join(', ')}"
+    end
+
+    def build_skipped_message(skipped)
+      "Skipped #{skipped.count} existing usernames"
+    end
+
+    def redirect_with_mixed_results(success_messages, failed)
+      error_messages = failed.map { |item| "Row #{item.line_number}: #{item.error_message}" }
+      alert_message = "#{failed.count} errors occurred: #{error_messages.join(', ')}"
+
+      if success_messages.any?
+        redirect_to admin_v2_students_path, notice: success_messages.join(". "), alert: alert_message
+      else
+        redirect_to admin_v2_students_path, alert: alert_message
+      end
+    end
   end
   # rubocop:enable Metrics/ClassLength
 end

app/views/admin_v2/students/index.html.erb

@@ -6,6 +6,11 @@
       <div class="flex justify-between items-center mb-4">
         <h3 class="text-lg font-semibold text-gray-900">Students</h3>
         <div class="flex gap-2">
+          <%= link_to "Template", template_admin_v2_students_path,
+                      class: "inline-flex items-center px-4 py-2 border border-gray-300 shadow-sm text-sm font-medium rounded-md text-gray-700 bg-white hover:bg-gray-50" %>
+          <%= link_to "Import Students", "#",
+                      onclick: "document.getElementById('import-modal').classList.remove('hidden'); return false;",
+                      class: "inline-flex items-center px-4 py-2 border border-gray-300 shadow-sm text-sm font-medium rounded-md text-gray-700 bg-white hover:bg-gray-50" %>
           <%= link_to "New Student", new_admin_v2_student_path,
                       class: "inline-flex items-center px-4 py-2 border border-transparent shadow-sm text-sm font-medium rounded-md text-white bg-blue-600 hover:bg-blue-700" %>
         </div>
@@ -90,3 +95,47 @@
     </div>
   </div>
 </div>
+
+<!-- Import Modal -->
+<div id="import-modal" class="hidden fixed inset-0 z-50 flex items-center justify-center" aria-labelledby="modal-title" role="dialog" aria-modal="true">
+  <!-- Background overlay -->
+  <div class="fixed inset-0 bg-gray-500 bg-opacity-75 transition-opacity" onclick="document.getElementById('import-modal').classList.add('hidden');"></div>
+
+  <!-- Modal content -->
+  <div class="relative bg-white rounded-lg shadow-xl max-w-lg w-full mx-4 z-50">
+    <div class="px-6 py-4">
+      <div class="flex justify-between items-center mb-4">
+        <h3 class="text-lg font-medium text-gray-900" id="modal-title">
+          Import Students from CSV
+        </h3>
+        <button type="button" class="text-gray-400 hover:text-gray-500" onclick="document.getElementById('import-modal').classList.add('hidden');">
+          <span class="sr-only">Close</span>
+          <svg class="h-6 w-6" fill="none" viewBox="0 0 24 24" stroke="currentColor">
+            <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M6 18L18 6M6 6l12 12" />
+          </svg>
+        </button>
+      </div>
+
+      <p class="text-sm text-gray-500 mb-4">
+        Upload a CSV file with columns: <strong>classroom_id, username</strong>
+      </p>
+
+      <%= form_with url: import_admin_v2_students_path, multipart: true, local: true do |form| %>
+        <div class="mb-4">
+          <%= form.file_field :csv_file,
+                              accept: ".csv",
+                              class: "block w-full text-sm text-gray-900 border border-gray-300 rounded-lg cursor-pointer bg-gray-50 focus:outline-none p-2" %>
+        </div>
+        <div class="flex justify-end gap-3">
+          <button type="button"
+                  onclick="document.getElementById('import-modal').classList.add('hidden');"
+                  class="inline-flex justify-center px-4 py-2 text-sm font-medium text-gray-700 bg-white border border-gray-300 rounded-md hover:bg-gray-50 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-blue-500">
+            Cancel
+          </button>
+          <%= form.submit "Import Students",
+                          class: "inline-flex justify-center px-4 py-2 text-sm font-medium text-white bg-blue-600 border border-transparent rounded-md hover:bg-blue-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-blue-500" %>
+        </div>
+      <% end %>
+    </div>
+  </div>
+</div>

config/routes.rb

@@ -89,6 +89,10 @@
     resources :school_years
     resources :stocks
     resources :students do
+      collection do
+        post :import
+        get :template
+      end
       member do
         patch :restore
         post :add_transaction

test/controllers/admin_v2/students_controller_test.rb

@@ -329,5 +329,173 @@ class StudentsControllerTest < ActionDispatch::IntegrationTest
       assert_redirected_to root_path
       assert_equal "Access denied. Admin privileges required.", flash[:alert]
     end
+
+    # Import/Template tests
+    test "template should download CSV template" do
+      get template_admin_v2_students_path
+
+      assert_response :success
+      assert_equal "text/csv", response.media_type
+      assert_equal "attachment; filename=\"student_import_template.csv\"", response.headers["Content-Disposition"]
+      assert_match(/classroom_id,username/, response.body)
+    end
+
+    test "import should create students from valid CSV" do
+      csv_content = "classroom_id,username\n#{@classroom1.id},import_student1\n#{@classroom2.id},import_student2"
+      csv_file = Tempfile.new(["test_import", ".csv"])
+      csv_file.write(csv_content)
+      csv_file.rewind
+
+      assert_difference("Student.count", 2) do
+        post import_admin_v2_students_path, params: {
+          csv_file: fixture_file_upload(csv_file.path, "text/csv")
+        }
+      end
+
+      csv_file.close
+      csv_file.unlink
+
+      assert_redirected_to admin_v2_students_path
+      assert_match(/Successfully created 2 students/, flash[:notice])
+      assert_match(/import_student1/, flash[:notice])
+      assert_match(/import_student2/, flash[:notice])
+    end
+
+    test "import should skip existing students" do
+      csv_content = "classroom_id,username\n#{@classroom1.id},student1\n#{@classroom2.id},new_student"
+      csv_file = Tempfile.new(["test_import", ".csv"])
+      csv_file.write(csv_content)
+      csv_file.rewind
+
+      assert_difference("Student.count", 1) do
+        post import_admin_v2_students_path, params: {
+          csv_file: fixture_file_upload(csv_file.path, "text/csv")
+        }
+      end
+
+      csv_file.close
+      csv_file.unlink
+
+      assert_redirected_to admin_v2_students_path
+      assert_match(/Successfully created 1 students/, flash[:notice])
+      assert_match(/Skipped 1 existing usernames/, flash[:notice])
+    end
+
+    test "import should handle errors and show line numbers" do
+      csv_content = "classroom_id,username\n999,invalid_student\n#{@classroom1.id},valid_student"
+      csv_file = Tempfile.new(["test_import", ".csv"])
+      csv_file.write(csv_content)
+      csv_file.rewind
+
+      post import_admin_v2_students_path, params: {
+        csv_file: fixture_file_upload(csv_file.path, "text/csv")
+      }
+
+      csv_file.close
+      csv_file.unlink
+
+      assert_redirected_to admin_v2_students_path
+      assert_match(/errors occurred/, flash[:alert])
+      assert_match(/Row 2:/, flash[:alert])
+    end
+
+    test "import should reject missing file" do
+      assert_no_difference("Student.count") do
+        post import_admin_v2_students_path
+      end
+
+      assert_redirected_to admin_v2_students_path
+      assert_equal "Please select a CSV file", flash[:alert]
+    end
+
+    test "import should handle malformed CSV" do
+      csv_content = "classroom_id,username\n1,\"unclosed quote\n2,another_row"
+      csv_file = Tempfile.new(["test_import", ".csv"])
+      csv_file.write(csv_content)
+      csv_file.rewind
+
+      assert_no_difference("Student.count") do
+        post import_admin_v2_students_path, params: {
+          csv_file: fixture_file_upload(csv_file.path, "text/csv")
+        }
+      end
+
+      csv_file.close
+      csv_file.unlink
+
+      assert_redirected_to admin_v2_students_path
+      assert_match(/Invalid CSV format/, flash[:alert])
+    end
+
+    test "import should handle empty CSV" do
+      csv_content = "classroom_id,username\n"
+      csv_file = Tempfile.new(["test_import", ".csv"])
+      csv_file.write(csv_content)
+      csv_file.rewind
+
+      assert_no_difference("Student.count") do
+        post import_admin_v2_students_path, params: {
+          csv_file: fixture_file_upload(csv_file.path, "text/csv")
+        }
+      end
+
+      csv_file.close
+      csv_file.unlink
+
+      assert_redirected_to admin_v2_students_path
+      assert_equal "No students found in CSV file", flash[:alert]
+    end
+
+    test "import should show both success and error messages" do
+      csv_content = "classroom_id,username\n#{@classroom1.id},import_success1\n999,import_fail\n#{@classroom2.id},import_success2"
+      csv_file = Tempfile.new(["test_import", ".csv"])
+      csv_file.write(csv_content)
+      csv_file.rewind
+
+      post import_admin_v2_students_path, params: {
+        csv_file: fixture_file_upload(csv_file.path, "text/csv")
+      }
+
+      csv_file.close
+      csv_file.unlink
+
+      assert_redirected_to admin_v2_students_path
+      assert_match(/Successfully created 2 students/, flash[:notice])
+      assert_match(/1 errors occurred/, flash[:alert])
+    end
+
+    test "non-admin cannot access template" do
+      sign_out(@admin)
+      teacher = create(:teacher)
+      sign_in(teacher)
+
+      get template_admin_v2_students_path
+
+      assert_redirected_to root_path
+      assert_equal "Access denied. Admin privileges required.", flash[:alert]
+    end
+
+    test "non-admin cannot import students" do
+      sign_out(@admin)
+      teacher = create(:teacher)
+      sign_in(teacher)
+
+      csv_content = "classroom_id,username\n#{@classroom1.id},import_student"
+      csv_file = Tempfile.new(["test_import", ".csv"])
+      csv_file.write(csv_content)
+      csv_file.rewind
+
+      assert_no_difference("Student.count") do
+        post import_admin_v2_students_path, params: {
+          csv_file: fixture_file_upload(csv_file.path, "text/csv")
+        }
+      end
+
+      csv_file.close
+      csv_file.unlink
+
+      assert_redirected_to root_path
+      assert_equal "Access denied. Admin privileges required.", flash[:alert]
+    end
   end
 end