Issue #4947: Update default text of distribution email #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cielf
requested changes
Feb 2, 2025
There was a problem hiding this comment.
Hi @jasonwang7517 Thanks for this -- and you're on the right track, except that you're displaying the partner's name and we need it to be the bank's name.
Note that the html isn't displaying properly, but we have someone working on that as a separate issue, so it's out of scope.
| @@ -328,7 +328,7 @@ | |||
| <div class="content"> | |||
|
|
|||
| <!-- START CENTERED WHITE CONTAINER --> | |||
| <span class="preheader">Your essentials request has been approved.</span> | |||
| <span class="preheader">You have a new distribution from <%= @partner.name %>. Please refer to the attachment for details.</span> | |||
There was a problem hiding this comment.
Alas, what we need is the essential bank's name here, and what you have is the partner's name. When you are manually testing, you should see "Pawnee Diaper Bank". Similarly on the text.
The bank's name can be found at @partner.organization.name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4947
Description
Type of change
How Has This Been Tested?
Screenshots