4682 sort partners alphabetical #4963
Open
+88
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatheerf02
force-pushed
the
4682-sort-partners-alphabetical
branch
from
3697912 to
4ee29c0
Compare
dorner
requested changes
Feb 2, 2025
| @@ -0,0 +1,48 @@ | |||
| RSpec.describe Admin::PartnersController, type: :controller do | |||
There was a problem hiding this comment.
Can you use a request test instead of a controller test? We really should be moving over the existing ones.
|
@cielf did you validate both fixes? This PR fixes two issues. |
|
Yes, I did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4682
Resolves #4674
Builds on top of #4703
Description
The super admin partners view is now in alphabetical order.
If you have an error on new item, the category list for selection will not disappear anymore.
Type of change
How Has This Been Tested?
I reopened the super admin page after implementing my changes and the partners are now in alphabetical order.
I tried to reproduce the bug after implement my bug fix and I was unable to do so (categories will show up now despite an error).
Everything else still works as expected.
Screenshots