Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank admins can enter requests on behalf of partners #4961

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jp524
Copy link
Contributor

@jp524 jp524 commented Jan 31, 2025

Resolves #4916

Description

This allows bank to enter requests on behalf on partners. As discussed in the issue, only bank admins can use this feature at this time. Bank users don't see the option when they are logged in.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added some new request and system specs. Ensured that existing tests still pass.
Also tested the feature locally (see demo below).

Screenshots

Bank admin entering new request

demo

Confirmation email

Screenshot 2025-01-30 at 18 07 16

@cielf cielf self-requested a review January 31, 2025 15:49
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good functionally -- 1 small functional change (that was missed in the issue), and over to @dorner for technicial input.

app/views/requests/_new.html.erb Outdated Show resolved Hide resolved
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just two minor quibbles.

app/controllers/partners/requests_controller.rb Outdated Show resolved Hide resolved
app/mailers/requests_confirmation_mailer.rb Outdated Show resolved Hide resolved
@jp524
Copy link
Contributor Author

jp524 commented Feb 2, 2025

The requested changes have all been addressed.
When going back to the code I found a couple of bugs related to validation so I've also addressed those.

Confirmation modal now showing confirmation modal
Validation errors now showing error message

@jp524 jp524 requested review from dorner and cielf February 2, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the capability for banks to enter requests on behalf of partners
3 participants