Minor fixes to Getting Started, plus reworking recommended inventory … #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…start to using Audits.
|
|
||
| - Do you (your bank) want to start out immediately with my partners making requests, or do you want to just track your distributions for awhile first? | ||
| - Do you run on a monthly cycle, or more on an adhoc basis? | ||
| - Do you (your bank) want to start out immediately with your partners making requests, or do you want to just track your distributions for awhile first? |
There was a problem hiding this comment.
Tiniest nit…I think it's a while when following a preposition and only awhile when used as an adverb.
Suggested change
| - Do you (your bank) want to start out immediately with your partners making requests, or do you want to just track your distributions for awhile first? | |
| - Do you (your bank) want to start out immediately with your partners making requests, or do you want to just track your distributions for a while first? |
There was a problem hiding this comment.
For a while looks weird to me though -- how about
Do you (your bank) want to start out immediately with your partners making requests, or do you want to just track your distributions awhile first?
| @@ -11,9 +11,9 @@ READY FOR REVIEW | |||
|
|
|||
| 4/ The usual way to handle bringing on Partners to be able to make Requests is to invite them, then have them fill in their profile before approving them, so that you get the information from them that your bank needs for grants, etc. However, if that's not how you want to work, it is also possible to invite and approve them in one step. | |||
|
|
|||
| 5/ A lot of Banks set up a Partner as a proxy for their direct distribution to people in need. This is allowed, and you can switch back and forth between being a Bank and a Partner with the same login | |||
| 5/ Many Banks set up a Partner as a proxy for their direct distribution to people in need. This is allowed, and you can switch back and forth between being a Bank and a Partner with the same login. | |||
There was a problem hiding this comment.
Note on Markdown formatting…I don't think it recognizes 5/ as anything semantic. If you use a . instead of a /, I believe it then generates html with <li> list items inside an overall <ol> ordered list.
It should also auto-fix any numbering typos, although that could sometimes be more confusing than helpful.
E.g., the following markdown
1. First item
2. Second
2. Thirdis formatted with correct numbering as
- First item
- Second
- Third
scooter-dangle
approved these changes
Feb 2, 2025
Co-authored-by: Scott Steele <[email protected]>
Co-authored-by: Scott Steele <[email protected]>
Co-authored-by: Scott Steele <[email protected]>
Co-authored-by: Scott Steele <[email protected]>
Co-authored-by: Scott Steele <[email protected]>
Co-authored-by: Scott Steele <[email protected]>
Co-authored-by: Scott Steele <[email protected]>
Co-authored-by: Scott Steele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor fixes to Getting Started, plus reworking recommended inventory start to using Audits.
Type of change