4241 change agency type to enum

app/models/partner.rb

@@ -71,6 +71,11 @@ class Partner < ApplicationRecord
     where(status: status.to_sym)
   }
 
+  # This constant mapping is preserved as it is a dependency of
+  # 20241122201255_cleanup_partner_agency_types.rb. In all other cases, one should
+  # refer to Partners::Profile.agency_types for a list of profile agency_types,
+  # and use I18n.t scope: :partners_profile to convert from an agency_type code
+  # to a descriptive string.
   AGENCY_TYPES = {
     "CAREER" => "Career technical training",
     "ABUSE" => "Child abuse resource center",
@@ -241,13 +246,14 @@ def agency_info
 
     return {} if profile.blank?
 
+    symbolic_agency_type = profile.agency_type&.to_sym
     @agency_info = {
       address: [profile.address1, profile.address2].select(&:present?).join(', '),
       city: profile.city,
       state: profile.state,
       zip_code: profile.zip_code,
       website: profile.website,
-      agency_type: (profile.agency_type == AGENCY_TYPES["OTHER"]) ? "#{AGENCY_TYPES["OTHER"]}: #{profile.other_agency_type}" : profile.agency_type
+      agency_type: (symbolic_agency_type == :other) ? "#{Partners::Profile.agency_types[:other]}: #{profile.other_agency_type}" : profile.agency_type
     }
   end
 

app/models/partners/profile.rb

@@ -95,6 +95,17 @@ class Profile < Base
     accepts_nested_attributes_for :served_areas, allow_destroy: true
 
     has_many_attached :documents
+    enum :agency_type, other: "OTHER", career: "CAREER", abuse: "ABUSE", bnb: "BNB",
+      church: "CHURCH", college: "COLLEGE", cdc: "CDC", health: "HEALTH",
+      outreach: "OUTREACH", legal: "LEGAL", crisis: "CRISIS", disab: "DISAB",
+      district: "DISTRICT", domv: "DOMV", ece: "ECE", child: "CHILD",
+      edu: "EDU", family: "FAMILY", food: "FOOD", foster: "FOSTER", govt: "GOVT",
+      headstart: "HEADSTART", homevisit: "HOMEVISIT", homeless: "HOMELESS",
+      hosp: "HOSP", infpan: "INFPAN", lib: "LIB", mhealth: "MHEALTH", military: "MILITARY",
+      police: "POLICE", preg: "PREG", presch: "PRESCH", ref: "REF", es: "ES",
+      hs: "HS", ms: "MS", senior: "SENIOR", tribal: "TRIBAL", treat: "TREAT",
+      twoycollege: "2YCOLLEGE", wic: "WIC"
+
     validate :check_social_media, on: :edit
 
     validate :client_share_is_0_or_100

app/services/reports/partner_info_report_service.rb

@@ -16,7 +16,7 @@ def report
 
       entries = { 'Number of Partner Agencies' => partner_agencies }
       partner_agency_counts.each do |agency, count|
-        entries["Agency Type: #{agency || 'Unknown'}"] = count
+        entries["Agency Type: #{(I18n.t agency, scope: [:partners_profile]) || 'Unknown'}"] = count
       end
       entries['Zip Codes Served'] = partner_zipcodes_serviced
       @report = { name: 'Partner Agencies and Service Area', entries: entries }

app/views/partners/profiles/edit/_agency_information.html.erb

@@ -8,7 +8,13 @@
           </div>
           <div class="card-body">
             <%= form.input :name, label: "Agency Name", class: "form-control", wrapper: :input_group %>
-            <%= profile_form.input :agency_type, collection: Partner::AGENCY_TYPES.values, label: "Agency Type", class: "form-control", wrapper: :input_group %>
+            <%= profile_form.input :agency_type,
+            # Symbolize keys, because simple_form will only do a I18n lookup for
+            # symbols
+              collection: Partners::Profile.agency_types.symbolize_keys.keys,
+              label: "Agency Type",
+              class: "form-control",
+              wrapper: :input_group %>
             <%= profile_form.input :other_agency_type, label: "Other Agency Type", class: "form-control", wrapper: :input_group %>
             <div class="form-group row">
               <label class="control-label col-md-3">501(c)(3) IRS Determination Letter or other Proof of Agency Status</label>

app/views/partners/profiles/show/_agency_information.html.erb

@@ -6,7 +6,7 @@
       <dd><%= profile.partner.name %></dd>
 
       <dt>Agency Type</dt>
-      <dd><%= profile.agency_type %></dd>
+      <dd><%= t profile.agency_type, scope: :partners_profile %></dd>
 
       <% if profile.agency_type == "Other" %>
         <dt>Other Agency Type</dt>

app/views/partners/profiles/step/_agency_information_form.html.erb

@@ -4,7 +4,13 @@
 
 <%= f.fields_for :profile, profile do |pf| %>
   <div class="form-group">
-    <%= pf.input :agency_type, collection: Partner::AGENCY_TYPES.values, label: "Agency Type",  class: "form-control", wrapper: :input_group %>
+    <%= pf.input :agency_type,
+    # Symbolize keys, because simple_form will only do a I18n lookup for
+    # symbols
+      collection: Partners::Profile.agency_types.symbolize_keys.keys,
+      label: "Agency Type",
+      class: "form-control",
+      wrapper: :input_group %>
   </div>
 
   <div class="form-group">

app/views/profiles/_show.html.erb

@@ -5,7 +5,7 @@
     <%# The field for inputting the name registers it as partner.name,  %>
     <%# not partner_profile.name, so this pulls from partner.name %>
     <p>Name: <%= @partner.name %></p>
-    <p>Agency Type: <%= partner_profile.agency_type %>
+    <p>Agency Type: <%= t partner_profile.agency_type, scope: :partners_profile %>
     <% if partner_profile.agency_type == "Other" && partner_profile.other_agency_type %>
       (<%= partner_profile.other_agency_type %>)
     <% end %>

config/locales/partners_profile.en.yml

@@ -0,0 +1,52 @@
+agency_type_map: &agency_type_map
+  other: "Other"
+  career: "Career technical training"
+  abuse: "Child abuse resource center"
+  bnb: "Basic Needs Bank"
+  church: "Church outreach ministry"
+  college: "College and Universities"
+  cdc: "Community development corporation"
+  health: "Community health program or clinic"
+  outreach: "Community outreach services"
+  legal: "Correctional Facilities / Jail / Prison / Legal System"
+  crisis: "Crisis/Disaster services"
+  disab: "Developmental disabilities program"
+  district: "School District"
+  domv: "Domestic violence shelter"
+  ece: "Early Childhood Education/Childcare"
+  child: "Early childhood services"
+  edu: "Education program"
+  family: "Family resource center"
+  food: "Food bank/pantry"
+  foster: "Foster Program"
+  govt: "Government Agency/Affiliate"
+  headstart: "Head Start/Early Head Start"
+  homevisit: "Home visits"
+  homeless: "Homeless resource center"
+  hosp: "Hospital"
+  infpan: "Infant/Child Pantry/Closet"
+  lib: "Library"
+  mhealth: "Mental Health"
+  military: "Military Bases/Veteran Services"
+  police: "Police Station"
+  preg: "Pregnancy resource center"
+  presch: "Preschool"
+  ref: "Refugee resource center"
+  es: "School - Elementary School"
+  hs: "School - High School"
+  ms: "School - Middle School"
+  senior: "Senior Center"
+  tribal: "Tribal/Native-Based Organization"
+  treat: "Treatment clinic"
+  twoycollege: "Two-Year College"
+  wic: "Women, Infants and Children"
+
+en:
+  partners_profile:
+    *agency_type_map
+
+  simple_form:
+    options:
+      profile:
+        agency_type:
+          *agency_type_map

db/migrate/20250116180121_convert_partner_agency_types_to_enum.rb

@@ -0,0 +1,77 @@
+class ConvertPartnerAgencyTypesToEnum < ActiveRecord::Migration[7.2]
+
+  def up
+    # A mapping from the lowercase full descriptive strings previously stored in
+    # agency_type to the newly enumerated values
+    string_to_value_mapping = {
+      "other" => "OTHER",
+      "career technical training" => "CAREER",
+      "child abuse resource center" => "ABUSE",
+      "basic needs bank" => "BNB",
+      "church outreach ministry" => "CHURCH",
+      "college and universities" => "COLLEGE",
+      "community development corporation" => "CDC",
+      "community health program or clinic" => "HEALTH",
+      "community outreach services" => "OUTREACH",
+      "correctional facilities / jail / prison / legal system" => "LEGAL",
+      "crisis/disaster services" => "CRISIS",
+      "developmental disabilities program" => "DISAB",
+      "school district" => "DISTRICT",
+      "domestic violence shelter" => "DOMV",
+      "early childhood education/childcare" => "ECE",
+      "early childhood services" => "CHILD",
+      "education program" => "EDU",
+      "family resource center" => "FAMILY",
+      "food bank/pantry" => "FOOD",
+      "foster program" => "FOSTER",
+      "government agency/affiliate" => "GOVT",
+      "head start/early head start" => "HEADSTART",
+      "home visits" => "HOMEVISIT",
+      "homeless resource center" => "HOMELESS",
+      "hospital" => "HOSP",
+      "infant/child pantry/closet" => "INFPAN",
+      "library" => "LIB",
+      "mental health" => "MHEALTH",
+      "military bases/veteran services" => "MILITARY",
+      "police station" => "POLICE",
+      "pregnancy resource center" => "PREG",
+      "preschool" => "PRESCH",
+      "refugee resource center" => "REF",
+      "school - elementary school" => "ES",
+      "school - high school" => "HS",
+      "school - middle school" => "MS",
+      "senior center" => "SENIOR",
+      "tribal/native-based organization" => "TRIBAL",
+      "treatment clinic" => "TREAT",
+      "two-year college" => "2YCOLLEGE",
+      "women, infants and children" => "WIC"
+    }
+
+    # Some agency types have trailing spaces -- need to get rid of them first
+    update 'UPDATE partner_profiles SET agency_type = TRIM(agency_type);'
+
+    profiles = Partners::Profile.all()
+    profiles.each do |profile|
+      # Read the agency_type without casting so values not part of the enum aren't
+      # read as nil
+      current_agency_type = profile.read_attribute_before_type_cast(:agency_type)
+      puts profile.id
+      puts current_agency_type
+      if !current_agency_type.nil?
+        # If a profile has a descriptive string (ignoring case) as an agency type
+        # update it to the associated value code.
+        if( string_to_value_mapping.key?( current_agency_type.downcase ) )
+          profile.agency_type = string_to_value_mapping[ current_agency_type.downcase ]
+        # If a profile has a value code (ignoring case) as an agency type, uppercase it.
+        elsif( string_to_value_mapping.value?( current_agency_type.upcase ) )
+          profile.agency_type = current_agency_type.upcase
+        end
+        profile.save!
+      end
+    end
+  end
+
+  def down
+    # Irreversible data migration
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.2].define(version: 2024_12_20_020009) do
+ActiveRecord::Schema[7.2].define(version: 2025_01_16_180121) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 

spec/models/partner_spec.rb

@@ -294,7 +294,7 @@
     let(:agency_state) { "ND" }
     let(:agency_zipcode) { "09980-7010" }
     let(:agency_website) { "bosco.example" }
-    let(:agency_type) { Partner::AGENCY_TYPES["OTHER"] }
+    let(:agency_type) { Partners::Profile.agency_types[:other] }
     let(:other_agency_type) { "Another Agency Name" }
     let(:notes) { "Some notes" }
     let(:providing_diapers) { {value: "N", index: 13} }
@@ -335,7 +335,7 @@
         agency_state,
         agency_zipcode,
         agency_website,
-        "#{Partner::AGENCY_TYPES["OTHER"]}: #{other_agency_type}",
+        "#{Partners::Profile.agency_types[:other]}: #{other_agency_type}",
         contact_name,
         contact_phone,
         contact_email,

spec/services/reports/partner_info_report_service_spec.rb

@@ -21,17 +21,17 @@
     context "with partners available" do
       let!(:p1) do
         create(:partner, :uninvited, organization: organization, name: 'Partner 1') do |p|
-          p.profile.update!(zips_served: '90210-1234', agency_type: Partner::AGENCY_TYPES['CAREER'])
+          p.profile.update!(zips_served: '90210-1234', agency_type: Partners::Profile.agency_types[:career])
         end
       end
       let!(:p2) do
         create(:partner, :uninvited, organization: organization, name: 'Partner 2') do |p|
-          p.profile.update!(zips_served: '12345', agency_type: Partner::AGENCY_TYPES['CAREER'])
+          p.profile.update!(zips_served: '12345', agency_type: Partners::Profile.agency_types[:career])
         end
       end
       let!(:p3) do
         create(:partner, :uninvited, organization: organization, name: 'Partner 3') do |p|
-          p.profile.update!(zips_served: '09876-3564', agency_type: Partner::AGENCY_TYPES['EDU'])
+          p.profile.update!(zips_served: '09876-3564', agency_type: Partners::Profile.agency_types[:edu])
         end
       end