4672: Fix for alignment of table heading and content #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What I'm seeing in your screen shots looks good -- just waiting for Audit |
prasath1196
changed the title
|
@cielf - fixed lint issues |
cielf
requested changes
Jan 6, 2025
There was a problem hiding this comment.
This issue was about making the alignment of the headers match the current alignment of the contents. In an ideal world, all numerics would already have been right-justified, but we were ok with leaving that for another issue.
But please don't change the numerics to text-left. Making the headers on numeric columns text-right should work?
Hope that clears up any confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4672
Description
Fix to Match header alignment to the contents on all tables to improve UI and readability.
Fixed the following pages:
Type of change
How Has This Been Tested?
Checked the UI manually
Screenshots