Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update default text of distribution email #4947

Open
2 tasks
cielf opened this issue Jan 26, 2025 · 6 comments · May be fixed by #4974
Open
2 tasks

update default text of distribution email #4947

cielf opened this issue Jan 26, 2025 · 6 comments · May be fixed by #4974
Assignees
@jasonwang7517
Labels
Good First Issue Suitable for users that are newer or less experienced

Comments

@cielf
Copy link
Collaborator

cielf commented Jan 26, 2025

Summary

The default text of the distribution email is inaccurate in some cases. Update it appropriately

Why

Could cause confusion

Details

To see the distribution email, on your local: sign in as [email protected]. Then click Distributions, then click the "New Distribution" button.
Fill in the form minimally -- choose a storage location, a partner, and add one item, with a quantity.
Save , and confirm.

In a few minutes the email will appear in your browser.

There is a different issue dealing with the fact that the styling is not right on this.

the default behaviour of the distribution email says "your request has been approved", even if was a distribution that wasn't from a request.

Change that text to:

You have a new distribution from [bank name]. Please refer to the attachment for details,

Criteria for completion

  • text changed
  • it is possible that this will break an existing test that depends on the text. If it does, update that test.
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Jan 26, 2025
@jasonwang7517
Copy link

I can take this!

@cielf
Copy link
Collaborator Author

cielf commented Jan 30, 2025

It's yours!

@jasonwang7517
Copy link

Apologies for the confusion here but I seem to be getting a little lost in this codebase.

I tried following the instructions to create a new distribution and managed to step through the user flow but didn't see the email pop up.

Then I tried searching the code base for the phrase "your request has been approved" which brought me to this file but this seems a little different and it also doesn't get passed the bank name for use in the new text.

Am I looking in the wrong place here?

@cielf
Copy link
Collaborator Author

cielf commented Jan 31, 2025

That looks like account requests rather than distributions...

Ah! The text is actually "Your essentials request has been approved." Which is found in partner_mailer.html.erb and partner_mailer.text.erb

@cielf
Copy link
Collaborator Author

cielf commented Jan 31, 2025

And.... the partner on the distribution has to have "Do you want this partner to receive emails for distributions and reminders from the system?" set.

@jasonwang7517
Copy link

Awesome, thanks for the helpful context! This clears things up.

@jasonwang7517 jasonwang7517 linked a pull request Feb 1, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonwang7517 jasonwang7517

Labels
Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #4947: Update default text of distribution email jasonwang7517/human-essentials
2 participants
@cielf @jasonwang7517