Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the capability for banks to enter requests on behalf of partners #4916

Open
2 tasks
cielf opened this issue Jan 5, 2025 · 5 comments · May be fixed by #4961
Open
2 tasks

Add the capability for banks to enter requests on behalf of partners #4916

cielf opened this issue Jan 5, 2025 · 5 comments · May be fixed by #4961

Comments

@cielf
Copy link
Collaborator

cielf commented Jan 5, 2025

Summary

Add a capability for banks to enter requests on behalf of their partners

Why?

This lets banks keep a record of requests that come in through other channels than the app. Adds capability to report for grant-writing purposes

Details

We can currently see the current requests from partners by signing in as [email protected] and clicking Requests
Add a button for "New Quantity Request" there

This will bring up a select partner screen, showing the partners for that bank. Once the partner is selected, we will bring up the same screen that the partner uses for requests, with the partner name clearly at the top. It will definitely require changes to the controller and views to allow using the provided partner instead of the currently logged in partner. The controller should only accept partners that belong to the current organization.

Add the partner name to the confirmation screen,

When creating the request, the current user should be put in as the partner user. Check all uses of request partner user to see if there are any unanticipated side effects. [We anticipate renaming the field in a future issue.]

An email will be sent to the partner when the request is saved. This email will go to the partner, and the person who entered the request (as it does now?) The email should say who entered the request (this is new).

We consider this a "high intermediate" task -- there may be gotchas.

Criteria for completion

  • Behaviour as described above
  • tests to confirm that behaviour
@jp524
Copy link
Contributor

jp524 commented Jan 17, 2025

I'd like to work on this!

@cielf
Copy link
Collaborator Author

cielf commented Jan 18, 2025

Please do!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Jan 18, 2025
@jp524
Copy link
Contributor

jp524 commented Jan 19, 2025

@cielf Are both bank users and bank admins allowed to enter requests on behalf of partners, or is it just bank admins?

@cielf
Copy link
Collaborator Author

cielf commented Jan 19, 2025

That is a fine question. I'll need to loop back with the stakeholders on that, but let's assume only the bank admins (we can always expand it.)

@cielf
Copy link
Collaborator Author

cielf commented Jan 20, 2025

@jp524 FYI - I've asked the question of the stakeholders in slack, but we probably won't get a firm decision until the next stakeholder circle. Please proceed as if it's only the bank admins.

@jp524 jp524 linked a pull request Jan 31, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants