Merged
Conversation
maebeale
changed the title
maebeale
commented
Feb 18, 2026
|
|
||
| def member_since_year | ||
| member_since ? member_since.year : nil | ||
| facilitator_since_date&.year |
Collaborator
Author
There was a problem hiding this comment.
we're moving forward assuming member_since meant facilitator since, and introducing affiliated since.
maebeale
commented
Feb 18, 2026
| status_active = joins(:organization_status).where(organization_statuses: { name: "Active" }) | ||
| affiliation_active = where(id: Affiliation.active.select(:organization_id)) | ||
| status_active.or(affiliation_active) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
using affiliations to determine active status now
maebeale
commented
Feb 18, 2026
| def published? # needed for my_bookmarks | ||
| organization_status&.name == "Active" | ||
| return true if organization_status&.name == "Active" | ||
| affiliations.active.exists? |
Collaborator
Author
There was a problem hiding this comment.
this has potential to be an issue. will leave it like this for now.
maebeale
commented
Feb 18, 2026
| "app/views/monthly_reports/edit.html.erb" => "admin-or-owner", | ||
|
|
||
| "app/views/notifications/show.html.erb" => "admin-or-owner", | ||
| "app/views/organizations/show.html.erb" => "admin-or-auth", |
Collaborator
Author
There was a problem hiding this comment.
this is moot for now until the feature is launched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
(these used to be manual fields, but now autocalculating based on associated affiliations, if present)
How did you approach the change?
Anything else to add?