Add tests for Kernel.sleep calling the Fiber scheduler hook #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herwinw
force-pushed
the
kernel_sleep_fiber_scheduler
branch
2 times, most recently
from
b8c88c6
to
902d5ca
Compare
herwinw
force-pushed
the
kernel_sleep_fiber_scheduler
branch
from
902d5ca
to
3ab4773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the pending issues for Ruby 3.0 (#823). This one has @aardvark179 in front of it, so I'm adding the same disclaimer as I did in #1064: I'm not trying to step on anybody's toes, but I was implementing this logic in Natalie, so I kind of needed these tests anyway.
The tests are pretty barebones checks to see if we call the scheduler with the correct arguments. A generic fiber scheduler has been added that logs the events, this one can be used in similar scheduler hooks tests as welll.
If there is need for an integration test kind of spec: I've written one for Natalie, it can be found at natalie-lang/natalie#1287 (with some weird code parts to work around some unrelated bugs), which can pretty much be copy-pasted.