Add ruby-3.4.0,ruby-3.4.1 #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Dec 28, 2024
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679
9 tasks
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
Dec 28, 2024
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
Dec 28, 2024
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679 rubocop/rubocop#13297 is required to pass the following spec on both Ruby versions before 3.3 and 3.4 and later: ```console 1) RuboCop::ConfigStore.for always uses config specified in command line Failure/Error: expect(config_store.for('file1')).to eq('merged {:options_config=>true}') expected: "merged {:options_config=>true}" got: "merged {options_config: true}" (compared using ==) # ./spec/rubocop/config_store_spec.rb:25:in 'block (3 levels) in <top (required)>' # tasks/spec_runner.rake:83:in 'RuboCop::SpecRunner::ParallelRunner#run_worker' # tasks/spec_runner.rake:38:in 'block in RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:52:in 'RuboCop::SpecRunner#with_encoding' # tasks/spec_runner.rake:36:in 'RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:164:in 'block in <top (required)>' ``` Consequently, the `rubocop_specs` test have been updated in v1.67.0 from v1.61.0, where this patch has been incorporated.
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
Dec 28, 2024
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679 rubocop/rubocop#13297 is required to pass the following spec on both Ruby versions before 3.3 and 3.4 and later: ```console 1) RuboCop::ConfigStore.for always uses config specified in command line Failure/Error: expect(config_store.for('file1')).to eq('merged {:options_config=>true}') expected: "merged {:options_config=>true}" got: "merged {options_config: true}" (compared using ==) # ./spec/rubocop/config_store_spec.rb:25:in 'block (3 levels) in <top (required)>' # tasks/spec_runner.rake:83:in 'RuboCop::SpecRunner::ParallelRunner#run_worker' # tasks/spec_runner.rake:38:in 'block in RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:52:in 'RuboCop::SpecRunner#with_encoding' # tasks/spec_runner.rake:36:in 'RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:164:in 'block in <top (required)>' ``` https://github.com/rubocop/rubocop-ast/actions/runs/12529029565/job/34944210256 Consequently, the `rubocop_specs` test have been updated in v1.67.0 from v1.61.0, where this patch has been incorporated.
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
Dec 28, 2024
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679 rubocop/rubocop#13297 is required to pass the following spec on both Ruby versions before 3.3 and 3.4 and later: ```console 1) RuboCop::ConfigStore.for always uses config specified in command line Failure/Error: expect(config_store.for('file1')).to eq('merged {:options_config=>true}') expected: "merged {:options_config=>true}" got: "merged {options_config: true}" (compared using ==) # ./spec/rubocop/config_store_spec.rb:25:in 'block (3 levels) in <top (required)>' # tasks/spec_runner.rake:83:in 'RuboCop::SpecRunner::ParallelRunner#run_worker' # tasks/spec_runner.rake:38:in 'block in RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:52:in 'RuboCop::SpecRunner#with_encoding' # tasks/spec_runner.rake:36:in 'RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:164:in 'block in <top (required)>' ``` https://github.com/rubocop/rubocop-ast/actions/runs/12529029565/job/34944210256
koic
added a commit
to koic/rubocop-ast
that referenced
this pull request
Dec 28, 2024
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679 rubocop/rubocop#13297 is required to pass the following spec on both Ruby versions before 3.3 and 3.4 and later: ```console 1) RuboCop::ConfigStore.for always uses config specified in command line Failure/Error: expect(config_store.for('file1')).to eq('merged {:options_config=>true}') expected: "merged {:options_config=>true}" got: "merged {options_config: true}" (compared using ==) # ./spec/rubocop/config_store_spec.rb:25:in 'block (3 levels) in <top (required)>' # tasks/spec_runner.rake:83:in 'RuboCop::SpecRunner::ParallelRunner#run_worker' # tasks/spec_runner.rake:38:in 'block in RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:52:in 'RuboCop::SpecRunner#with_encoding' # tasks/spec_runner.rake:36:in 'RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:164:in 'block in <top (required)>' ``` https://github.com/rubocop/rubocop-ast/actions/runs/12529029565/job/34944210256 Therefore, RuboCop used in `rubocop_specs` has been updated to v1.69.2, the version released with Ruby 3.4.
koic
added a commit
to rubocop/rubocop-ast
that referenced
this pull request
Dec 28, 2024
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679 rubocop/rubocop#13297 is required to pass the following spec on both Ruby versions before 3.3 and 3.4 and later: ```console 1) RuboCop::ConfigStore.for always uses config specified in command line Failure/Error: expect(config_store.for('file1')).to eq('merged {:options_config=>true}') expected: "merged {:options_config=>true}" got: "merged {options_config: true}" (compared using ==) # ./spec/rubocop/config_store_spec.rb:25:in 'block (3 levels) in <top (required)>' # tasks/spec_runner.rake:83:in 'RuboCop::SpecRunner::ParallelRunner#run_worker' # tasks/spec_runner.rake:38:in 'block in RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:52:in 'RuboCop::SpecRunner#with_encoding' # tasks/spec_runner.rake:36:in 'RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:164:in 'block in <top (required)>' ``` https://github.com/rubocop/rubocop-ast/actions/runs/12529029565/job/34944210256 Therefore, RuboCop used in `rubocop_specs` has been updated to v1.69.2, the version released with Ruby 3.4.
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Dec 30, 2024
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Dec 30, 2024
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated PR from ruby/ruby-builder