Remove deprecated and unused Gem::List
#9161
Open
+0
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated and unused Gem::List class that was marked for removal. The class was previously deprecated and is now being fully removed from the codebase.
- Deleted the entire
lib/rubygems/util/list.rbfile containing theGem::Listclass implementation - Removed all
require_relative "util/list"statements from files that imported it - Updated the project manifest to reflect the file removal
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/rubygems/util/list.rb | Deleted file containing the deprecated Gem::List class and its implementation |
| lib/rubygems/specification.rb | Removed unused require statement for util/list |
| lib/rubygems/resolver.rb | Removed unused require statement for util/list |
| Manifest.txt | Removed lib/rubygems/util/list.rb entry from project manifest |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to remove this at 4.0.0. It will be removed at 4.1.0 release.