Change @scanner.match to respond nil/@scanner in order to impro…

…ve processing speed.
ruby · Jan 15, 2024 · 995d3e2 · 995d3e2
1 parent 61aff5c
commit 995d3e2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/lib/rexml/parsers/baseparser.rb b/lib/rexml/parsers/baseparser.rb
@@ -274,8 +274,7 @@ def pull_event
             return [ :elementdecl, @source.match( ELEMENTDECL_PATTERN, true )[1] ]
 
           when ENTITY_START
-            match = @source.match( ENTITYDECL, true ).compact
-            match[0] = :entitydecl
+            match = [:entitydecl, *@source.match( ENTITYDECL, true ).captures.compact]
             ref = false
             if match[1] == '%'
               ref = true

diff --git a/lib/rexml/source.rb b/lib/rexml/source.rb
@@ -70,11 +70,10 @@ def read
 
     def match(pattern, cons=false)
       if cons
-        @scanner.scan(pattern)
+        @scanner.scan(pattern).nil? ? nil : @scanner
       else
-        @scanner.check(pattern)
+        @scanner.check(pattern).nil? ? nil : @scanner
       end
-      @scanner.matched? ? [@scanner.matched, *@scanner.captures] : nil
     end
 
     # @return true if the Source is exhausted
@@ -158,24 +157,24 @@ def read
 
     def match( pattern, cons=false )
       if cons
-        @scanner.scan(pattern)
+        md = @scanner.scan(pattern)
       else
-        @scanner.check(pattern)
+        md = @scanner.check(pattern)
       end
-      while !@scanner.matched? and @source
+      while md.nil? and @source
         begin
           @scanner << readline
           if cons
-            @scanner.scan(pattern)
+            md = @scanner.scan(pattern)
           else
-            @scanner.check(pattern)
+            md = @scanner.check(pattern)
           end
         rescue
           @source = nil
         end
       end
 
-      @scanner.matched? ? [@scanner.matched, *@scanner.captures] : nil
+      md.nil? ? nil : @scanner
     end
 
     def empty?