Fix an error when using Parser gem with prism_result
#382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an error when using Parser gem with `prism_result`. https://github.com/rubocop/rubocop/actions/runs/15497886582/job/43638843391?pr=14251 Since Ruby LSP 0.24 or later, `prism_result` is now passed as a `Prism::ParseLexResult`. As a result, the following build error occurs in RuboCop for the Ruby LSP add-on. The processing that uses `prism_result` assumes Prism and cannot be performed when using the Parser gem.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jun 6, 2025
… 0.24 This PR is a workaround to avoid the following build error in the Ruby LSP add-on test with Ruby LSP 0.24. https://github.com/rubocop/rubocop/actions/runs/15497886582/job/43638843391?pr=14251 The build error will be resolved in rubocop/rubocop-ast#382.
Merged
8 tasks
|
Thanks! Released as 1.45.1 |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jun 12, 2025
Follow-up to rubocop/rubocop-ast#382. This PR fixes the following build error on when using Parser gem with `prism_result` and Ruby LSP >= 0.24. https://github.com/rubocop/rubocop/actions/runs/15497886582/job/43638843391?pr=14251
8 tasks
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Jun 12, 2025
Follow-up to rubocop/rubocop-ast#382. This PR fixes the following build error on when using Parser gem with `prism_result` and Ruby LSP >= 0.24. https://github.com/rubocop/rubocop/actions/runs/15497886582/job/43638843391?pr=14251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error when using Parser gem with
prism_result. https://github.com/rubocop/rubocop/actions/runs/15497886582/job/43638843391?pr=14251Since Ruby LSP 0.24 or later,
prism_resultis now passed as aPrism::ParseLexResult. As a result, the following build error occurs in RuboCop for the Ruby LSP add-on.The processing that uses
prism_resultassumes Prism and cannot be performed when using the Parser gem.