Fix RuboCop::AST::NumericNode#sign? to return boolean

changelog/fix_numeric_node_sign_to_return_boolean.md

@@ -0,0 +1 @@
+* [#380](https://github.com/rubocop/rubocop-ast/pull/380): Fix `RuboCop::AST::NumericNode#sign?` to return boolean. ([@viralpraxis][])

lib/rubocop/ast/node/mixin/numeric_node.rb

@@ -15,7 +15,7 @@ module NumericNode
       #
       # @return [Boolean] whether this literal has a sign.
       def sign?
-        source.match(SIGN_REGEX)
+        source.match?(SIGN_REGEX)
       end
     end
   end

spec/rubocop/ast/float_node_spec.rb

@@ -10,16 +10,18 @@
   end
 
   describe '#sign?' do
+    subject { float_node.sign? }
+
     context 'explicit positive float' do
       let(:source) { '+42.0' }
 
-      it { is_expected.to be_sign }
+      it { is_expected.to be(true) }
     end
 
     context 'explicit negative float' do
       let(:source) { '-42.0' }
 
-      it { is_expected.to be_sign }
+      it { is_expected.to be(true) }
     end
   end
 

spec/rubocop/ast/int_node_spec.rb

@@ -10,16 +10,18 @@
   end
 
   describe '#sign?' do
+    subject { int_node.sign? }
+
     context 'explicit positive int' do
       let(:source) { '+42' }
 
-      it { is_expected.to be_sign }
+      it { is_expected.to be(true) }
     end
 
     context 'explicit negative int' do
       let(:source) { '-42' }
 
-      it { is_expected.to be_sign }
+      it { is_expected.to be(true) }
     end
   end
 

spec/rubocop/ast/rational_node_spec.rb

@@ -10,16 +10,18 @@
   end
 
   describe '#sign?' do
+    subject { rational_node.sign? }
+
     context 'when explicit positive rational' do
       let(:source) { '+0.2r' }
 
-      it { is_expected.to be_sign }
+      it { is_expected.to be(true) }
     end
 
     context 'when explicit negative rational' do
       let(:source) { '-0.2r' }
 
-      it { is_expected.to be_sign }
+      it { is_expected.to be(true) }
     end
   end