Support RuboCop::AST::ComplexNode
#379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2025
koic
force-pushed
the
support_rubocop_ast_complex_node
branch
from
8b16098 to
90c3098
Compare
This PR supports `RuboCop::AST::ComplexNode`. The `complex` type is categorized as a `numeric` type, so it should be handled transparently alongside `int`, `float`, and `rational`. ```ruby int: :numeric, float: :numeric, rational: :numeric, complex: :numeric, ``` https://github.com/rubocop/rubocop-ast/blob/v1.44.1/lib/rubocop/ast/node.rb#L106-L109 This eliminates the need for redundant branching, such as in rubocop/rubocop#14146.
koic
force-pushed
the
support_rubocop_ast_complex_node
branch
from
90c3098 to
de62cd7
Compare
|
Oh, sorry about missing the notifications for this. Thank you! |
|
Released as v1.46.0 |
koic
added a commit
to rubocop/rubocop
that referenced
this pull request
Jul 18, 2025
5hun-s
pushed a commit
to 5hun-s/rubocop
that referenced
this pull request
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports
RuboCop::AST::ComplexNode.The
complextype is categorized as anumerictype, so it should be handled transparently alongsideint,float, andrational.https://github.com/rubocop/rubocop-ast/blob/v1.44.1/lib/rubocop/ast/node.rb#L106-L109
This eliminates the need for redundant branching, such as in rubocop/rubocop#14146.