Add more filters for CodeExplorer import command #5731
Conversation
Add additional filters. Cache filter index for reuse next time dialog is shown.
| ImportableExtensions.Where(ext => !ext.EndsWith("doccls")) | ||
| .Select(ext => $"*{ext}")); | ||
|
|
||
| private string StandardModuleExtension => "*" + ImportableExtensions.Where(ext => ext.EndsWith("bas")).First(); |
There was a problem hiding this comment.
My concern with using First() is that it becomes a runtime error that will blow upmif the assumption about file extensions being unique and present is violated.
I probably would use ‘FirstOrDefault()and ifnull`, do not concatenate into the filter. Then I would add an unit test to assert that the contents are unique and has valid extensions, thus preventing a time bomb.
Add member to create individual filters and member to concatenate individual filter for dialogs filter.
Converted members to local functions since both members are used in only one location. They can only be used within the containing member and simplifies the member list on the type.
Caches filter index last chosen for next import. Filter index is saved to config file to continue using last chosen index went starting a new instance of RD.
When filter index matches cached/config index no save occurs. When filter index differs from cached/config index save occurs.
Cancelling an import does not change filter index. Saving does not occur.
IvenBach
force-pushed
the
Issue5395_Filters_for_synchronizing_document_types
branch
from
71f4cc9
to
eaf0ef9
Compare
Restore inital null check and model mockProjectSettingsProvider after it. Constructor inject dependencies.
…or_synchronizing_document_types
|
Marking this PR as blocked for now, since it introduces new resource keys. |
|
Does the same go for the other resource editing PRs? |
|
@IvenBach I haven't looked at the conflicts, do they look salvageable? If they become mergeable after the release, I'll merge them, but the "resource freeze" window is closing soon, and then every new resource key will probably conflict again. |
|
Most of them were minor at worst. Will review each one to update then push each branch. |
|
You'll probably want to resolve the conflicts on #5749 first, have it merged (I'd like to merge it sooner than later!), and then sync [next] with your dev branch here and address these conflicts. |
MDoerner
added
the
PR-Status: Conflicting
Vogel612
added
the
up-for-grabs
Close #5395
Add additional filters. Cache filter index for reuse next time dialog is shown.