-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Nyx version 2.0.0-beta #16
Conversation
WARNING: The dependencies use branches instead of versions!
Awesome, thank you for the effort !
It is problematic to me to require internet acces on first deployment. Why is this file (or a more simplistic option) not simply shipped with the library ? especially considering they are hosted as metadata in the library already (not a third party portal). I would recommend moving to a Cargo build script (rust code triggered by compilation), or other options to trigger some scripts at compilation time. If you have never used a Cargo build script (which I doubt) you can refer to the one contained in the rinex library, which has the benefit of being simple. It provides the description of the navigation radio messages as specificied by the standards. You will find those in the tokio or mavlink frameworks as well, but they are much more complex
To me, this is the only final option. Having maybe an optional input overriden by a default solution. For actual behavior and tests, refer to the PR in RINEX |
I understand your use case. I'll propose using |
You must copy add the DE440s.bsp file to the data folder for rinex. Rinex expects that this file be available in the AstroData structure. I could not add it myself because Github doesn't allow adding git lfs to public forks WARNING: The DE440s.bsp file is large. Once nyx-space/anise#262 is fixed, you should truncate this DE file to only contain a few years and a few planetary ephemerides instead of the whole solar system
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
I don't have permission to push git-lfs on this fork so you will have to do it yourself. |
Ok! Once ANISE 0.4 is published in an hour (after dinner), I will update this PR so that it uses the |
Sounds good. I'm upgrading all my gnss toolkit to hifitime=4.0.0-alpha, so my side should not be blocking. |
Signed-off-by: Guillaume W. Bres <[email protected]>
Yes, that's right, Nyx still need to be released, and I'll work on that in the coming days too. By the weekend, all three packages will have a release. |
Hello, could we get a Nyx branch that uses the same hifitime version as the others ? we do not need a release |
Hi. Yes, the master branch uses 4.0.0-alpha, and used anise 0.4.0, which
also uses 4.0.0-alpha.
…On Tue, Jul 2, 2024, 23:23 gwbres ***@***.***> wrote:
Hello, could we get a Nyx branch that uses the same hifitime version as
the others ? we do not need a release
—
Reply to this email directly, view it on GitHub
<#16 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEZV2CBHGXNZH5XORCW2T3ZKODDZAVCNFSM6AAAAABJXY3AN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVGEZDENRTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thank you I did not catch that! ; ) |
You can now use |
Signed-off-by: Guillaume W. Bres <[email protected]>
I'm OK with merging these new features, even without nyx-space/anise#269 as a temporary phase. This topic is more of long term and final target than immediate requirement. Once this topic is "resolved" it will naturaly modify the behavior and requirements |
Signed-off-by: Guillaume W. Bres <[email protected]>
I will merge this very soon, most likely tomorrow I am unavailable right now. Either way I'm merging and we will improve later, i am personaly done with not being able to work on my own stuff |
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
This change switches the Eclipse computation to 2.0.0-beta, with ANISE as a backend.
The main question I have is whether the user should provide the Almanac for the
Solver
structure. The Almanac contains the planetary data and solar system data needed for all of the computations. Hence, it may be useful for the user to provide that depending on their use case, even though in theory, everyone's definition of Earth is the same. If all one needs to do is change the gravitational parameter, then that can be done directly with methods on the [Frame])(https://docs.rs/anise/latest/anise/frames/struct.Frame.html) object.In the case of the eclipse computation, we actually need to provide tri-axial ellipsoid information to define the shape of the object. But worry not! This data is available in the
pck08.pca
(andpck11.pca
) files that are in the ANISE repo or on the Nyx cloud. TheMetaFile
structure will automatically download the provided URL if the data does not exist in the user's local temporary directory, or if the CRC of that file does not match the version that is downloaded.