Do not limit async priority with NVIC_PRIO_BITS when targeting ESP32-C3
#996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
force-pushed
the
fixes/esp32c3-codegen-bindings
branch
from
5829525 to
9b245db
Compare
|
Sorry, forgot I had a PR open with this branch and force pushed 😅 |
jessebraham
force-pushed
the
fixes/esp32c3-codegen-bindings
branch
from
9b245db to
912a6be
Compare
korken89
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since RISC-V devices do not have an NVIC, we set the
nvicPrioBitsfield in our SVDs simply to 0. As such, this value should not be used to determine the maximum async priority, and I have aligned the codegen bindings for this target with theriscv_slicversion.